search

damiensellier / CtrlrX

CtlrX is an alternative fork of Roman Kubiak's Ctrlr. This project is ONLY aimed at delivering updates, a wiki, documentations, tutorials or anything that the community cannot share on the original Ctrlr github due to credential restrictions.
BSD 3-Clause "New" or "Revised" License
16 stars 3 forks source link

Red colour for close button on mouse over #29

Closed damiensellier closed 6 days ago

damiensellier commented 6 days ago

Source\UIComponents\CtrlrApplicationWindow\CtrlrDocumentPanel.cpp Row 195 and further

   else if (isMouseOverButton)
    {
        //g.setColour (Colour(findColour(TextButton::buttonOnColourId)).brighter(0.4));
//        g.setColour (Colour (0xdfe7e7e8));
        g.setColour (Colour (0xffcc7878));      // Light red (I saw 0xffff1100 somewhere else)

        g.fillRoundedRectangle((float) (proportionOfWidth (0.0500f)),
                               (float) (proportionOfHeight (0.0500f)),
                               (float) (proportionOfWidth (0.9000f)),
                               (float) (proportionOfHeight (0.9000f)),
                               (float) (proportionOfWidth(0.1f)));

//        g.setColour(Colour(0xdf3f3e45));
        g.setColour(Colour(0xffffffff));
        g.fillPath (internalPath3);

//        g.setColour(Colour(0xdf3f3e45));
        g.setColour(Colour(0xffffffff));
        g.fillPath (internalPath4);
    }

light red can be red 0xffff0000 ou 0xffff1100

damiensellier commented 6 days ago 
    else if (isMouseOverButton)
    {
        //g.setColour (Colour(findColour(TextButton::buttonOnColourId)).brighter(0.4)); // v.5.2.198
        //g.setColour (Colour (0xdfe7e7e8)); // Added v5.6.30
        //g.setColour (Colours::red); // Added v5.6.31 by GoodWeather
        g.setColour (findColour(TextButton::buttonOnColourId));; // Added v5.6.31

        g.fillRoundedRectangle((float) (proportionOfWidth (0.0500f)),
                               (float) (proportionOfHeight (0.0500f)),
                               (float) (proportionOfWidth (0.9000f)),
                               (float) (proportionOfHeight (0.9000f)),
                               (float) (proportionOfWidth(0.1f)));

        //g.setColour (Colour (0xdf3f3e45)); // Added v5.6.30
        g.setColour (Colours::white); // Added v5.6.31
        g.fillPath (internalPath3);

        //g.setColour (Colour (0xdf3f3e45)); // Added v5.6.30
        g.setColour (Colours::white); // Added v5.6.31
        g.fillPath (internalPath4);
    }

Capture d’écran, le 2024-06-29 à 16 57 41

Capture d’écran, le 2024-06-29 à 16 58 19

Capture d’écran, le 2024-06-29 à 16 57 53

dobo365 commented 5 days ago

In order to not mix the meaning of things, I think that it should be red (0xffcc7878) and not change with the panel...

damiensellier commented 5 days ago

Let's go for red ;) 

else if (isMouseOverButton)
    {
        //g.setColour (Colour(findColour(TextButton::buttonOnColourId)).brighter(0.4)); // v.5.2.198
        //g.setColour (Colour (0xdfe7e7e8)); // Added v5.6.30
        g.setColour (Colours::red); // Added v5.6.31 by GoodWeather
        //g.setColour (findColour(TextButton::buttonOnColourId));; // Added v5.6.31

        g.fillRoundedRectangle((float) (proportionOfWidth (0.0500f)),
                               (float) (proportionOfHeight (0.0500f)),
                               (float) (proportionOfWidth (0.9000f)),
                               (float) (proportionOfHeight (0.9000f)),
                               (float) (proportionOfWidth(0.1f)));

        //g.setColour (Colour (0xdf3f3e45)); // Added v5.6.30
        g.setColour (Colours::white); // Added v5.6.31
        g.fillPath (internalPath3);

        //g.setColour (Colour (0xdf3f3e45)); // Added v5.6.30
        g.setColour (Colours::white); // Added v5.6.31
        g.fillPath (internalPath4);
    }