damienvanrobaeys / About_my_device

About my device: A systray tool for that displays device information and run action like send logs or sync device
34 stars 6 forks source link

Hardcoded for Windows 10? #14

Open JanVinterberg opened 1 year ago

JanVinterberg commented 1 year ago

Hi Damien, I kept wondering why my device kept mentioning that my device was a Windows 10 (being on Win11) https://github.com/damienvanrobaeys/About_my_device/blob/ada9466cff7abb0e991a90c30806291031326b17/Sources/About_this_computer.ps1#L584

Can see that the line is hardcoded to show Windows 10 and then the current $Release number

JanVinterberg commented 1 year ago

Was thinking that you could source the Product name from $REG_OS_Version in L557, but then found there is a bug/feature in that registry key from MS, as mine shows Windows 10 Enterprise, but (Get-ciminstance Win32_OperatingSystem).Caption results in the correct Windows 11 Enterprise.

JanVinterberg commented 1 year ago

fixed my line 584 with $OS_Version.Content = "$($Win32_OperatingSystem.Caption) - $Release" which then states: "Microsoft Windows 11 Enterprise - 22H2" could remove the Microsoft part, but didn't bother ;)