damienvanrobaeys / Run-in-Sandbox

Run PS1, VBS, CMD, EXE, MSI, Intunewin, MSIX, or extract ISO, ZIP in Windows Sandbox very quickly just from a right-click
https://www.systanddeploy.com/2023/06/runinsandbox-quick-way-to-runextract.html
699 stars 82 forks source link

Context menu for some extensions is missing #18

Closed akuropka closed 1 year ago

akuropka commented 2 years ago

Windows 22000.346

I downloaded the whole set as ZIP (Run-in-Sandbox-master) and extracted it. Afterwards I ran the .\Add_Structure.ps1 which completed without error (running it again without prior remove produces ResourceExists-errors).

The context menu for EXE is there and seems to work. But others are not available... how to track the issue down?

Thank you! (-:

20211116_160939_explorer 20211116_160735_explorer 20211116_160641_explorer 20211116_160825_explorer 20211116_160700_explorer

RunInSandbox_Install.log

orestisthebeast commented 1 year ago

Hi there and thank you for your work. I am also on Windows 10 and can confirm that all context menus apart from .PS1 are working. Any pointers?

Joly0 commented 1 year ago

Hi there and thank you for your work. I am also on Windows 10 and can confirm that all context menus apart from .PS1 are working. Any pointers?

Hey, i have a fork https://github.com/Joly0/Run-in-Sandbox which i have a pr open aswell (hasnt been merged yet). I have fixed alot of issues i had with this version, maybe it helps you too. Could you maybe try that and see, if it works? If not, please open an issue over there and i will look into it asap

orestisthebeast commented 1 year ago

Joly0's fork works on Win10, confirmed.

Thank you so much!

Joly0 commented 1 year ago

Joly0's fork works on Win10, confirmed.

Thank you so much!

You’re welcome

ak47uk commented 1 year ago

In case it helps anyone, I could not get this to work with PS1, all other extensions I tested were ok. Notepad++ was set as my default for PS1, I ran Remove_Structure.ps1, reset all default apps in Windows 11, ran Add_Structure.ps1 and then it worked. I got this error on every run, including the successful one and using Joly0 fork: [05/17/23 15:04:48] - INFO : Checking programs from: Registry::HKEY_USERS\S-1-12-1-...\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.ps1\UserChoice Test-Path : Cannot bind argument to parameter 'Path' because it is null. At C:\Users\USER\Run-in-Sandbox-master\Add_Structure.ps1:296 char:18 + If (Test-Path $HKCR_UserChoice_Shell) { + ~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidData: (:) [Test-Path], ParameterBindingValidationException + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.TestPathCommand

Joly0 commented 1 year ago

In case it helps anyone, I could not get this to work with PS1, all other extensions I tested were ok. Notepad++ was set as my default for PS1, I ran Remove_Structure.ps1, reset all default apps in Windows 11, ran Add_Structure.ps1 and then it worked. I got this error on every run, including the successful one and using Joly0 fork: [05/17/23 15:04:48] - INFO : Checking programs from: Registry::HKEY_USERS\S-1-12-1-...\Software\Microsoft\Windows\CurrentVersion\Explorer\FileExts\.ps1\UserChoice Test-Path : Cannot bind argument to parameter 'Path' because it is null. At C:\Users\USER\Run-in-Sandbox-master\Add_Structure.ps1:296 char:18 + If (Test-Path $HKCR_UserChoice_Shell) { + ~~~~~~~~~~~~~~~~~~~~~~ + CategoryInfo : InvalidData: (:) [Test-Path], ParameterBindingValidationException + FullyQualifiedErrorId : ParameterArgumentValidationErrorNullNotAllowed,Microsoft.PowerShell.Commands.TestPathCommand

I think i have fixed this, opened a pr for it

ak47uk commented 1 year ago

I think i have fixed this, opened a pr for it

That works now, many thanks!

damienvanrobaeys commented 1 year ago

Could ou please try with the new version ?

ak47uk commented 1 year ago

Could ou please try with the new version ?

Looking good now, thanks

damienvanrobaeys commented 1 year ago

thanks :-)