search

damionx7 / Zettel-Notes-Documentation

Documentation for Zettel Notes : Markdown Note Taking app for android
https://znotes.thedoc.eu.org/
GNU General Public License v3.0
48 stars 4 forks source link

Performance regression while text is in a RTL language and line numbering is On #92

Closed chromer030 closed 3 months ago

chromer030 commented 3 months ago

In RTL markdown notes (Persian, Arabic), if you turn on line numbering, the scrolling performance in edit mode would be worst.

1- Turn on line numbering in Settings 2- Open a long RTL-language note 3 - try to scroll note

In same file turning off line numbering, bring back smoothness of scrolling.

damionx7 commented 3 months ago

Hey! Can you try updating the app (v2.6.0) and see if this issue exists.

I have updated the app on f-droid for now. https://thedoc.eu.org/fdroid/repo/zettel-notes-20600.apk.

chromer030 commented 3 months ago

Tested 2.6.0 and fixed, thank you.

Another minor issue is status bar color change:

Screenshot_20240620-214009_Zettel_Notes_1

QuickEdit app:

Screenshot_20240620-215040_QuickEdit+_1

damionx7 commented 3 months ago

You are most welcome.

This status bar color change is intentional. Do you want same color for toolbar and status bar ?

chromer030 commented 3 months ago

You are great man.

Could it be an option in Settings to enable/disable status bar color change?

I would like seamless view of app while all colors are in shape and order.

chromer030 commented 3 months ago

Another somehow annoying issue:

In RTL-Languages texts, scrollbar covers the first characters of notes:

https://github.com/damionx7/Zettel-Notes-Documentation/assets/13361552/050fe6b6-8911-4f47-84d7-57dbf9f7cb4b

https://github.com/damionx7/Zettel-Notes-Documentation/assets/13361552/ef00267a-8b50-4e87-9050-54bf3ed2550b

I tried : Note Margin > Right > 16 But yet it covers first character A better solution would be best ...

chromer030 commented 3 months ago

Another minor issue:

Customized Text color reverts to white (default).

1- Changing Text color and selecting theme (Cyberpumk in my case) 2- Came back to note without closing app, text color is changed and OK. 2- But after closing and reopening the app, note is in white not selected color!

damionx7 commented 3 months ago

I will try to fix these issues.

damionx7 commented 3 months ago

Another minor issue:

Customized Text color reverts to white (default).

1- Changing Text color and selecting theme (Cyberpumk in my case) 2- Came back to note without closing app, text color is changed and OK. 2- But after closing and reopening the app, note is in white not selected color!

I can't replicate this issue. Can you please share a video. It would help in solving this issue.

damionx7 commented 3 months ago

Another somehow annoying issue:

In RTL-Languages texts, scrollbar covers the first characters of notes: 2024_06_24_22_57_25_trim.mp4 rec.mp4

I tried : Note Margin > Right > 16 But yet it covers first character A better solution would be best ...

I have added settings option in Settings > Editor and Viewer to change scrollbar size.

chromer030 commented 3 months ago

I can't replicate this issue. Can you please share a video. It would help in solving this issue.

I solved it by creating new theme and not editing current ones, iissue happens when we edit current default themes, the edited colors doesnt apply after two times reopening of app.

We can ignore this, creating new theme with desired colors is solution.