[teammates/TEAMMATES] Issues Digest

[github-actions[bot]]

Subscribe to this issue to receive a digest of all the issues in this repository.

[github-actions[bot]]

Digest Summary: 2023-07-24 23:35:31

... contains 16 changes across 7 issues, since 2023-07-14 23:35:30 (timezone: Singapore)

# Instructor courses page: some items don't show spinners [#10508](https://github.com/TEAMMATES/teammates/issues/10508) `@rexong` created this [comment](https://github.com/TEAMMATES/teammates/issues/10508#issuecomment-1636993318) on 2023-07-16 14:22:38 >Hi, can I start a PR for this? `@domlimm` created this [comment](https://github.com/TEAMMATES/teammates/issues/10508#issuecomment-1636995891) on 2023-07-16 14:36:27 >@rexong Sure, feel free to submit a PR! # Instructor sending submission reminders: missing space between checkbox and label [#12313](https://github.com/TEAMMATES/teammates/issues/12313) `@Venkateeshh` created this [comment](https://github.com/TEAMMATES/teammates/issues/12313#issuecomment-1637050492) on 2023-07-16 18:46:02 >Is anyone working on this issue still?? > `@weiquu` created this [comment](https://github.com/TEAMMATES/teammates/issues/12313#issuecomment-1637054333) on 2023-07-16 19:07:04 >Nope, @Venkateeshh feel free to submit a PR for this issue # Refactoring of sortable tables [#12329](https://github.com/TEAMMATES/teammates/issues/12329) `@weiquu` modified this issue on 2023-07-24 18:20:09 >Sortable tables are used in several pages, but a fair number of them don't make use of the `sortable-table` component. Searching `sortable` amongst `.html` files should bring up these 10 (unlikely to be more, but best to do a more thorough search): > >- [ ] Extension confirm modal >- [ ] Per question view responses >- [ ] Sessions recycle bin table >- [x] Sessions table (Completed: #12501) >- [ ] Student list >- [ ] Notifications table >- [ ] Copy instructors from other courses modal >- [ ] Instructor courses page >- [ ] Copy questions from other sessions modal >- [ ] Instructor session individual extension page > >It would be good to refactor the above components to make use of the `sortable-table` component to avoid duplication. Some other components, like the contribution question statistics component and the MCQ question statistic component, already make use of that component, so they can be referenced. `@singhabhyudita` created this [comment](https://github.com/TEAMMATES/teammates/issues/12329#issuecomment-1642976978) on 2023-07-20 09:36:25 >Hi, I'll be taking up the Instructor courses page. Hope that's okay? `@weiquu` created this [comment](https://github.com/TEAMMATES/teammates/issues/12329#issuecomment-1647633211) on 2023-07-24 18:21:15 >> Hi, I'll be taking up the Instructor courses page. Hope that's okay? > >Sure, do note the changes to the `sortable-table` component that was introduced in #12501 # Flickering questions when loading sessions results [#12499](https://github.com/TEAMMATES/teammates/issues/12499) `@tushargupta123` created this [comment](https://github.com/TEAMMATES/teammates/issues/12499#issuecomment-1640058247) on 2023-07-18 19:42:09 >Hey can i correct the issue ? > `@domlimm` created this [comment](https://github.com/TEAMMATES/teammates/issues/12499#issuecomment-1640059845) on 2023-07-18 19:43:33 >@tushargupta123 Hello, feel free to submit a PR for this. # Nonspecific error messages on E2E tests [#12513](https://github.com/TEAMMATES/teammates/issues/12513) `@wkurniawan07` created this [comment](https://github.com/TEAMMATES/teammates/issues/12513#issuecomment-1637024721) on 2023-07-16 16:37:57 >This is not as simple as it sounds. > >The nature of the verification is different: this is waiting for some event to happen, in this case for a toast with specified message to appear. Consider this scenario: > >- Toast with the modified message appears in page >- Verification fails; wait for the specified timeout >- Another toast with totally unrelated message appears in page >- Verification fails > >The suggested expected behaviour will compare the unrelated message, which is hardly any better. Granted that the chance of toast with unrelated message appearing is low, but it should show why it is not as simple as "show expected vs actual message". # V8.28.1 [#12520](https://github.com/TEAMMATES/teammates/issues/12520) `@damithc` created and modified this issue on 2023-07-15 11:39:02 > > >Scheduled for Saturday, Jul 15, 2023, ~10.00pm~ 10.00am SGT. > >Release Lead: > >- [x] Tagged the latest stable release code with the latest version number >- [x] Released changelogs > >PM: > >- [x] Deployed the new version >- [x] Released the new version for end users > `@samuelfangjw` created this [comment](https://github.com/TEAMMATES/teammates/issues/12520#issuecomment-1636602313) on 2023-07-15 09:04:40 >[V8.28.1](https://github.com/TEAMMATES/teammates/releases/tag/V8.28.1) has been released by @samuelfangjw at July 15th, 2023, 09.01am SGT. > >Code contributions from: @Zxun2 >Review contributions from: @domlimm, @weiquu > >Ready for post-release check and deployment by PM (@damithc). `@damithc` created this [comment](https://github.com/TEAMMATES/teammates/issues/12520#issuecomment-1636643447) on 2023-07-15 11:39:21 >Deployed and released. Thanks again for the quick patch release. 💯 # Save all comments when saving responses for all questions [#12527](https://github.com/TEAMMATES/teammates/issues/12527) `@zhaojj2209` created this issue on 2023-07-22 23:34:02 >Currently, the "Submit Responses to All Questions" button does not save comments. Given that comments for responses are now allowed for all question types (see #12426), it is all the more important that comments are saved along with the responses. `@Saimurugeshwari` created this [comment](https://github.com/TEAMMATES/teammates/issues/12527#issuecomment-1646955298) on 2023-07-24 04:43:36 >can I work on this issue. `@jasonqiu212` created this [comment](https://github.com/TEAMMATES/teammates/issues/12527#issuecomment-1647212160) on 2023-07-24 13:00:56 >Hi @Saimurugeshwari, sure! Feel free to submit a PR for this issue