damithc / foo

0 stars 0 forks source link

Error msg in add command #110

Open nus-pe-bot opened 3 years ago

nus-pe-bot commented 3 years ago

[destination: nus-tic4002-AY2021S2/pe-moderation assignee: boydanderson labels: response.Rejected severity.Low team.3 tutorial.TIC4002-F18 type.FunctionalityBug pending.0]

Summary of items to check:

Nothing to check :-)



Issue Description

When add a person with some missing information, e.g. no phone number or email address, app will displayed below error message.

Screenshot 2021-04-16 at 8.05.42 PM.png

However, if add phone number after the address, the app also allows to add the person.

Therefore, the add command do not have to follow the orders displayed in the error message. It makes the error message a bit redundant, it dose not tell user exactly what to do. For example, in this case, it should the phone number is missing rather than an invalid command format.


[original: Yiheng0410/pe#5]

Team's Response

Base on the user guide, the order of the information can be changed, and name, phone, email and address are necessary information that must be included. Thus, this is not a bug.

To Check [0 Items]

Nothing to check :-)

soc-se-bot-blue commented 1 year ago

I noticed this too.

damithc commented 1 year ago

When add a person with some missing information, e.g. no phone number or email address, app will displayed below error message.

Screenshot 2021-04-16 at 8.05.42 PM.png

Seems legit.

soc-se-script commented 6 months ago

Seems this issue is stale. Close?