search

damithc / foo

0 stars 0 forks source link

[teammates/TEAMMATES] Issues Digest #119

Open github-actions[bot] opened 11 months ago

github-actions[bot] commented 11 months ago

Subscribe to this issue to receive a digest of all the issues in this repository.

github-actions[bot] commented 11 months ago

Digest Summary: 2023-07-24 06:21:14

... contains 20 changes across 9 issues, since 2023-07-14 06:21:13 (timezone: Singapore)

 # Instructor courses page: some items don't show spinners [#10508](https://github.com/TEAMMATES/teammates/issues/10508) `@rexong` created this [comment](https://github.com/TEAMMATES/teammates/issues/10508#issuecomment-1636993318) on 2023-07-16 14:22:38 >Hi, can I start a PR for this? `@domlimm` created this [comment](https://github.com/TEAMMATES/teammates/issues/10508#issuecomment-1636995891) on 2023-07-16 14:36:27 >@rexong Sure, feel free to submit a PR! # Instructor sending submission reminders: missing space between checkbox and label [#12313](https://github.com/TEAMMATES/teammates/issues/12313) `@Venkateeshh` created this [comment](https://github.com/TEAMMATES/teammates/issues/12313#issuecomment-1637050492) on 2023-07-16 18:46:02 >Is anyone working on this issue still?? > `@weiquu` created this [comment](https://github.com/TEAMMATES/teammates/issues/12313#issuecomment-1637054333) on 2023-07-16 19:07:04 >Nope, @Venkateeshh feel free to submit a PR for this issue # Refactoring of sortable tables [#12329](https://github.com/TEAMMATES/teammates/issues/12329) `@singhabhyudita` created this [comment](https://github.com/TEAMMATES/teammates/issues/12329#issuecomment-1642976978) on 2023-07-20 09:36:25 >Hi, I'll be taking up the Instructor courses page. Hope that's okay? # Flickering questions when loading sessions results [#12499](https://github.com/TEAMMATES/teammates/issues/12499) `@tushargupta123` created this [comment](https://github.com/TEAMMATES/teammates/issues/12499#issuecomment-1640058247) on 2023-07-18 19:42:09 >Hey can i correct the issue ? > `@domlimm` created this [comment](https://github.com/TEAMMATES/teammates/issues/12499#issuecomment-1640059845) on 2023-07-18 19:43:33 >@tushargupta123 Hello, feel free to submit a PR for this. # Nonspecific error messages on E2E tests [#12513](https://github.com/TEAMMATES/teammates/issues/12513) `@wkurniawan07` created this [comment](https://github.com/TEAMMATES/teammates/issues/12513#issuecomment-1637024721) on 2023-07-16 16:37:57 >This is not as simple as it sounds. > >The nature of the verification is different: this is waiting for some event to happen, in this case for a toast with specified message to appear. Consider this scenario: > >- Toast with the modified message appears in page >- Verification fails; wait for the specified timeout >- Another toast with totally unrelated message appears in page >- Verification fails > >The suggested expected behaviour will compare the unrelated message, which is hardly any better. Granted that the chance of toast with unrelated message appearing is low, but it should show why it is not as simple as "show expected vs actual message". # Release V8.28.0 [#12514](https://github.com/TEAMMATES/teammates/issues/12514) `@damithc` modified this issue on 2023-07-14 21:15:35 > > >Scheduled for Friday, Jul 14, 2023, 10.30pm SGT. > >Release Lead: > >- [x] Tagged the latest stable release code with the latest version number >- [x] Released changelogs > >PM: > >- [x] Deployed the new version >- [ ] Released the new version for end users > `@samuelfangjw` created this [comment](https://github.com/TEAMMATES/teammates/issues/12514#issuecomment-1635788816) on 2023-07-14 20:24:42 >[V8.28.0](https://github.com/TEAMMATES/teammates/releases/tag/V8.28.0) has been released by @samuelfangjw at July 14th, 2023, 08.19pm SGT. > >Code contributions from: @LarsGielen, @NicolasCwy, @Sho-Shoo, @YvetteJian, @Zxun2, @anuth212, @aorlandou, @athakaras, @b-walton, @damoba, @domoberzin, @ellaella12, @guilherme-puida, @hollymvargas, @itsAfnanAlam, @justincavalli, @landa44, @leonardomilv3, @rai31218, @rhyses-pieces, @riotgage, @ryalin, @singhabhyudita, @techMedMau, @yash29896, @yujioshiro, @zhaojj2209 >Review contributions from: @EuniceSim142, @cedricongjh, @domlimm, @jasonqiu212, @weiquu, @zhaojj2209 > >Ready for post-release check and deployment by PM (@damithc). `@damithc` created this [comment](https://github.com/TEAMMATES/teammates/issues/12514#issuecomment-1635850308) on 2023-07-14 21:15:22 >Thanks everyone who contributed 💯 >Deployed but reverted to previous version as there is a minor bug #12517 that needs to be fixed first. # Instructors creating sessions: response visible time should be 'not now' by default [#12517](https://github.com/TEAMMATES/teammates/issues/12517) `@damithc` created this issue on 2023-07-14 21:11:57 >When an instructors is creating a new session, > >Current: > >![image](https://github.com/TEAMMATES/teammates/assets/1673303/877ffd12-0628-4dd0-8177-4b7e5b26d49b) > >The default `Make response visible` time is empty. > >Expected: > >Should be set to `Not now`. > >Otherwise, there will be an error message upon saving. > >Seems like a regression caused by V8.28 > `@damithc` created this [comment](https://github.com/TEAMMATES/teammates/issues/12517#issuecomment-1635848496) on 2023-07-14 21:13:59 >Possibly caused by #12498 >@Zxun2 can have a look? `@Zxun2` created and modified this [comment](https://github.com/TEAMMATES/teammates/issues/12517#issuecomment-1635981853) on 2023-07-14 23:07:48 >Apologies, I have submitted a PR for this! `@damithc` created this [comment](https://github.com/TEAMMATES/teammates/issues/12517#issuecomment-1636018008) on 2023-07-14 23:22:44 >> Apologies, I have submitted a PR for this! > >No worries @Zxun2 . It's a rite of passage 😀 >Thanks for the quick response. # V8.28.1 [#12520](https://github.com/TEAMMATES/teammates/issues/12520) `@damithc` created and modified this issue on 2023-07-15 11:39:02 > > >Scheduled for Saturday, Jul 15, 2023, ~10.00pm~ 10.00am SGT. > >Release Lead: > >- [x] Tagged the latest stable release code with the latest version number >- [x] Released changelogs > >PM: > >- [x] Deployed the new version >- [x] Released the new version for end users > `@samuelfangjw` created this [comment](https://github.com/TEAMMATES/teammates/issues/12520#issuecomment-1636602313) on 2023-07-15 09:04:40 >[V8.28.1](https://github.com/TEAMMATES/teammates/releases/tag/V8.28.1) has been released by @samuelfangjw at July 15th, 2023, 09.01am SGT. > >Code contributions from: @Zxun2 >Review contributions from: @domlimm, @weiquu > >Ready for post-release check and deployment by PM (@damithc). `@damithc` created this [comment](https://github.com/TEAMMATES/teammates/issues/12520#issuecomment-1636643447) on 2023-07-15 11:39:21 >Deployed and released. Thanks again for the quick patch release. 💯 # Save all comments when saving responses for all questions [#12527](https://github.com/TEAMMATES/teammates/issues/12527) `@zhaojj2209` created this issue on 2023-07-22 23:34:02 >Currently, the "Submit Responses to All Questions" button does not save comments. Given that comments for responses are now allowed for all question types (see #12426), it is all the more important that comments are saved along with the responses. `@Saimurugeshwari` created this [comment](https://github.com/TEAMMATES/teammates/issues/12527#issuecomment-1646955298) on 2023-07-24 04:43:36 >can I work on this issue.