search

damko / freedommarks-browser-webextension

A cross-browser webextension for Nextcloud Bookmarks
https://addons.mozilla.org/en-US/firefox/addon/freedommarks/
GNU General Public License v2.0
106 stars 15 forks source link

Link to my bookmarks does not work #12

Open vgay opened 6 years ago

vgay commented 6 years ago

Thanks for your extension.

my nextcloud server url is https://ncloud.zaclys.com

if I save it like this adding new bookmarks works fine, but the link to see my bookmarks page doesn't.

this link should be : https://ncloud.zaclys.com/index.php/apps/bookmarks/

but index.php is missing and it is https://ncloud.zaclys.com/apps/bookmarks/

Sorry for my bad english.

damko commented 6 years ago

Hello, you are welcome.

Most likely the rewrite rule on your webserver (nginx or Apache) is not configured properly. Have a look at the nextcloud admin guide for further details

On 13 July 2018 12:30:09 GMT+02:00, vgay notifications@github.com wrote:

Thanks for your extension.

my nextcloud server url is https://ncloud.zaclys.com

if I save it like this adding new bookmarks works fine, but the link to see my bookmarks page doesn't.

this link should be : https://ncloud.zaclys.com/index.php/apps/bookmarks/

but index.php is missing and it is https://ncloud.zaclys.com/apps/bookmarks/

Sorry for my bad english.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/damko/freedommarks-browser-webextension/issues/12

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

damko commented 6 years ago

Btw Your English is fine! :-)

On 13 July 2018 12:30:09 GMT+02:00, vgay notifications@github.com wrote:

Thanks for your extension.

my nextcloud server url is https://ncloud.zaclys.com

if I save it like this adding new bookmarks works fine, but the link to see my bookmarks page doesn't.

this link should be : https://ncloud.zaclys.com/index.php/apps/bookmarks/

but index.php is missing and it is https://ncloud.zaclys.com/apps/bookmarks/

Sorry for my bad english.

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/damko/freedommarks-browser-webextension/issues/12

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

slavoutich commented 5 years ago

I think that the link without index.php is valid for Apache-based setup and invalid for PHP-FPM-based (don't know the reason why). For Apache https://cloud.example.com/index.php/apps/bookmarks/ should forward to https://cloud.example.com/apps/bookmarks/, therefore, putting in the addon link with index.php would be universal.

damko commented 5 years ago

@slavoutich I understand what you mean. The thing is that, if you still have index.php in the way then you didn't configure correctly the rewrite parameter in your Apache configuration. However you might be right, leaving the index.php could be more universal. I'm gonna check this as soon as I can (very swamped in this period)

slavoutich commented 5 years ago

@damko Not necessary me, that's the problem, in my case I rent an instance from a cloud provider and don't manage the webserver. Anyway, no rush, this issue is far from being critical :) Thanks for the extension, btw!

damko commented 5 years ago

yes, yes I gotcha.

Btw, FYI: I'm pretty sure that if you update nextcloud to the latest version, my addon will break.

I should come up with a new version in days

aquada commented 5 years ago

Hi I'm also getting this problem. Looking forward to the fix. thank you. my url for bookmarks is nextcloud.domain.com/index.php/apps/bookmarks

Sixthhokage1 commented 5 years ago

The thing is that, if you still have index.php in the way then you didn't configure correctly the rewrite parameter in your Apache configuration.

Unfortunately at present for those of us using the Nextcloud snap package, rewrite configuration to remove "index.php/" is not possible (see nextcloud/nextcloud-snap#412)