search

damko / freedommarks-browser-webextension

A cross-browser webextension for Nextcloud Bookmarks
https://addons.mozilla.org/en-US/firefox/addon/freedommarks/
GNU General Public License v2.0
106 stars 15 forks source link

Chrome seems to be broken #13

Open binarious opened 6 years ago

binarious commented 6 years ago

I have the extension installed in Firefox and Chrome with the same configurations. It does work in Firefox but doesn't in Chrome. The developer console shows constant redirects (302) to the target Nextcloud instance.

damko commented 6 years ago

yes, sorry about that. The bug is confirmed since a while but I had no time to look into it and won't have for a while. I accept PRs, just saying

binarious commented 6 years ago

Alright. Going to look into it.

binarious commented 6 years ago

@damko Do you have a short instruction on how to get this running locally in chrome? Just adding the src folder as an extension leads to:

Unrecognized manifest key 'applications'.

Update: Nevermind. It still works. Seems to be a warning.

damko commented 6 years ago

you need to go in developer mode https://developer.chrome.com/extensions/getstarted

binarious commented 6 years ago

Debugged for some time. Copied the exact same request chrome sends and put that into a REST api client (Insomia). I don't get a 302 there. Also used apache_request_headers in the index.php on my nextcloud instance to output the headers - no difference either.

It works with Chromium and Chrome Canary (70).

People from the Passman webextension have similar issues: https://github.com/nextcloud/passman-webextension/issues/258

Will try some other things when I find more time.

damko commented 6 years ago

In fact, if it works in FF it should also work in Chrome. It's a weird behavior. Anyway, thanks for the effort

marcelklehr commented 6 years ago

@damko I've had the same issue in floccus, here's the fix: https://github.com/nextcloud/passman-webextension/pull/270

binarious commented 6 years ago

Thanks @marcelklehr. Created a PR based on this.

damko commented 5 years ago

thanks guys, very appreciated. I'm awfully swamped therefore I didn't yet have the chance to look into it. I'll do asap