search

damko / freedommarks-browser-webextension

A cross-browser webextension for Nextcloud Bookmarks
https://addons.mozilla.org/en-US/firefox/addon/freedommarks/
GNU General Public License v2.0
106 stars 15 forks source link

Merge changes into official bookmark app? #2

Open e-alfred opened 7 years ago

e-alfred commented 7 years ago

Hello,

this is a very useful extension for bookmarks (the best I have seen until now), so it would be great to get your changes to the bookmarks app into the official one. This would make any modification on the server side needless and only the browser component would be needed which makes it very easy to handle.

Thank you

xXSTrikeXx commented 7 years ago

Would be great to hear sth. new about it. Looks great, but for me the installation step is to much to using it ;)

dcrobertson01 commented 6 years ago

I installed the modified app, but Nextcloud went and updated to the official one again. Would like to see this working - be a very useful tool.

e-alfred commented 6 years ago

I installed the latest 0.0.7 release and it works with the official bookmark app from the Nextcloud store so far.

It would be great if @damko sends his patches upstream as a PR, but the app is going through a major redesign at the moment anyway.

sunjam commented 6 years ago

@e-alfred it would be great if @blizzz from Nextcloud Bookmarks app, @damko from FreedomMarks, @marcelklehr from Floccus bookmark app would all work together. I believe that unifying your visions and code changes would benefit us all!

marcelklehr commented 6 years ago

Hello everyone :) :wave: This is already happening, or rather: already happened. damko's bugfixes have been part of a pull request (https://github.com/nextcloud/bookmarks/pull/417), which was subject to objections, which were not resolved, which caused the changes to be integrated individually in different pull requests and the original PR by @damko to be closed. Apart from some css changes the master branch of nextcloud/bookmarks now has all necessary fixes for freedommarks to work, as far as I can tell. You just need to wait for the next release, which should be rather soon-ish ;)

Cheers and happy nextclouding!

damko commented 6 years ago

hello everyone, thanks for showing appreciation :-) I'm sorry for being late with my replies but I've been drowning lately in too many other things. Good news is that I've a little free time these days so I'm going to work on this. If you have some feature-requests this is a good time to bring them up.

@marcelklehr I'm sorry for the last messy PR. I just needed the app to work for my own needs as soon as possible. Now I go to check how code has been merged, then I'll update my fork to mainstream. You can expect some PR starting from today.