search

damko / freedommarks-browser-webextension

A cross-browser webextension for Nextcloud Bookmarks
https://addons.mozilla.org/en-US/firefox/addon/freedommarks/
GNU General Public License v2.0
106 stars 15 forks source link

add autocompletion for tags #21

Open schiessle opened 5 years ago

schiessle commented 5 years ago

First let me say thank you for this great browser plugin. I really like it! :slightly_smiling_face:

The main thing I miss: It would be great if I could autocomplete existing tags both when I create a new bookmark and in the tags search. Especially when I create a new bookmark it would be good to see what tags already exists to avoid to end up with many similar tags.

damko commented 5 years ago

I'm happy you like it

Tag completion is definitely in the todo list. The main issue was related to the API on the server side. Time ago I wrote a patch for that but then there were many changes in the API and was dropped/postponed. Now the development of the API should be stable and it's a good time for implementing new features but I don't have the time

schiessle commented 5 years ago

As the webinterface already provide auto-completion for tags I was curious how it works and if their might be a internal API which we could easily make public to allow apps like yours to use it as well.

It seems like it does something way more simple. It just fetches all tags and then do the auto-completion client side. This would be already possible for your app as well. A GET request against following endpoint will give you all available tags:

https://<nextcloudserver>/index.php/apps/bookmarks/public/rest/v2/tag

Maybe you could use this endpoint as well to implement tag auto-completion?

damko commented 5 years ago

it has been a few months that I don't look at the bookmarks repo but as long as I can remember the REST API and the internal API are two different things, as you noticed.

yes, I planned to do tags autocomplete client side. I just don't have time