damko / freedommarks-browser-webextension

A cross-browser webextension for Nextcloud Bookmarks
https://addons.mozilla.org/en-US/firefox/addon/freedommarks/
GNU General Public License v2.0
106 stars 15 forks source link

When saving bookmarks in Firefox on version 0.7, tag is not added #5

Closed sunjam closed 6 years ago

sunjam commented 6 years ago

When saving a bookmark via the Freedommarks 0.7 firefox extension, url and description sync to my 12.0.5 server, but tags are not saved.

damko commented 6 years ago

This is very weird. Can you save tags from the web interface (in nextcloud) ?

sunjam commented 6 years ago

Just having a problem with Freedommarks. Any specific logs I should share?

On Sat, Feb 24, 2018 at 1:12 PM Damiano Venturin notifications@github.com wrote:

This is very weird. Can you save tags from the web interface (in nextcloud) ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/damko/freedommarks-browser-webextension/issues/5#issuecomment-368260649, or mute the thread https://github.com/notifications/unsubscribe-auth/ABtFZouFk__OrJAbXY9vuZzi5wLly3Unks5tYHsqgaJpZM4SRqzI .

damko commented 6 years ago

About logs: I'll give you instructions in the next days. I need to check something on the nextcloud side. If you upgraded from a previous Freedommarks version, please try this:

As far as I can tell, you are the only one having this kind of issue and, to be honest, I believe that there is something wrong on the nextcloud installation on server side. Maybe nextcloud bookmarks has been updated and I need to adjust something in Freedommarks. However I've planned to publish a new release in a couple of weeks. Hold tight meanwhile.

Thanks for reporting

bepolymathe commented 6 years ago

Hello,

I have the same problem. Firefox 59

damko commented 6 years ago

bug confirmed and partially diagnosed. It definitely has something to do with the recent changes in the API server side. It was working on nextcloud 12.x but after upgrading to 13.1 tags don't get saved anymore. I'll look into it asap

n1mh commented 6 years ago

Hi,

I have the same problem and it's probably related with nextcloud 13. Before that version it worked great with tags.

bepolymathe commented 6 years ago

It is true that this is a disabling problem. It would be great if you could do something... Thank you in advance.

damko commented 6 years ago

yes definitely related to changes in the API for bookmark-apps version 0.11.

I'm looking into it now

damko commented 6 years ago

I'm going to upload v.0.0.8 which fixes this bug. Tags now can be added to a new bookmark via FreedomMarks. Be aware though that updating already existent tags won't work. I'm not yet sure what is this due too. I'll diagnose in the next days.

bepolymathe commented 6 years ago

Hello,

I confirm it works.