search

damoclark / buzzer.click

Buzzer.click is an online synchronous quiz game that implements a fun ‘buzzer’ type system, such that during a contested response to a question, the first person to ‘buzz’ is identified and thus has first opportunity to answer.
8 stars 3 forks source link

Bunch of incomplete improvements by Damo - for review before merging … #2

Closed damoclark closed 8 years ago

damoclark commented 8 years ago

…into dev

. Figured out jsonschema (see fix in test-jsonschema.js) . Initial implementation of Error handling both in network protocol and error throwing . Implemented more message classes

To run functional test between client/server, start: node server.js node browser.js

damoclark commented 8 years ago

Sorry for the state of this commit/PR. Was uncommitted changes to code when I stopped working on it.

We can talk about it during a weekly catch up when you are both ready to look at it, and I can answer any questions.

D.

pleb commented 8 years ago

Looks good to me. I think we should merge it as is let this be the point where we start the app development. I would be interested to see what @nick2170 thinks?

nick2170 commented 8 years ago

Yea I had a look today, if anything it gives us a better starting point.

On 25 Jul 2016 18:38, "Wade Baglin" notifications@github.com wrote:

Looks good to me. I think we should merge it as is let this be the point where we start the app development. I would be interested to see what @nick2170 https://github.com/nick2170 thinks?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/damoclark/buzzer.click/pull/2#issuecomment-234888449, or mute the thread https://github.com/notifications/unsubscribe-auth/ATgjMbq3SlV4vbEUiLmIF7jqOL4lVPBcks5qZHYNgaJpZM4JTitb .