search

damoebius / haxe-npm

The Cross-Platform Toolkit
19 stars 4 forks source link

npm-haxe takeover :) #12

Open clemos opened 8 years ago

clemos commented 8 years ago

https://github.com/clemos/npm-haxe has more features :

IMHO the way you handle -lib to avoid haxelib dependency is just wrong : https://github.com/damoebius/haxe-npm/blob/master/bin/haxe-cli.js#L20-L22 -cp is not at all the same as -lib :

I think this is extremely confusing to transform / break the user's command like this...

also, the npm page is not up to date https://www.npmjs.com/package/haxe (still refers to old externs + bootstrapping)

So, how about publishing my package to npm.org/haxe ?

clemos commented 8 years ago

Also, I highly doubt most of the npm packages published via haxelib.js will work.

For instance : https://www.npmjs.com/package/haxe-react has its source set to src/lib : https://github.com/massiveinteractive/haxe-react/blob/master/haxelib.json

Have you tested it ?

JbIPS commented 8 years ago

IMO, it's better to let Haxe handle the libs as it does in @clemos package. Haxe would be just a sandbox in the node_modules. This way, it doesn't break the user system and let Haxe magic untouched.

lexoyo commented 8 years ago

For instance : https://www.npmjs.com/package/haxe-react has its source set to src/lib : https://github.com/massiveinteractive/haxe-react/blob/master/haxelib.json

tried it, it does not work with my setup not sure why

damoebius commented 8 years ago

There is many good things in your module and as i said i have no problems to use yours. I'll go to the next wwx, can we talk about it there ?

clemos commented 8 years ago

I'd really like to solve this quickly, so I guess wwx would be too late...

damoebius commented 8 years ago

But actually your module doesn't work on my ubuntu. Maybe you should fix it first ?

@lexoyo you have to use -lib with the path to the source folder like "-lib haxereact/src"

clemos commented 8 years ago

Please file an issue on my repo

damoebius commented 8 years ago

I'll :-) Why wwx is too late ?

clemos commented 8 years ago

I think we've waited long enough, and the situation is pretty urgent, now. IMO, the Haxe presence on NPM currently hurts its own credibility.

Regarding the bugs you seem to encounter using my package: It's been 2 times you've raised bugs without even starting to report them. Not to mention your first tweet was obviously more an attempt to publicly discredit my work than constructive criticism. I'm ok with you including parts of my work into yours, as I'm all for OSS, but please try to be helpful and to show some respect.

sledorze commented 8 years ago

I would love to see joint effort on that matter!

damoebius commented 8 years ago

I think we've waited long enough, and the situation is pretty urgent, now. IMO, the Haxe presence on NPM currently hurts its own credibility.

Waited for what ? We have been using haxe on npm in production for 2 years This is your opinion, l never heard something like that before. As a collaborator, why are you reporting it just now ?

Regarding the bugs you seem to encounter using my package: It's been 2 times you've raised bugs without even starting to report them. Not to mention your first tweet was obviously more an attempt to publicly discredit my work than constructive criticism.

Are you kidding me ? I hope so because this is very hurtful. I always wanted to work with you, i offered to, i gave you all access to this repo, i asked you to test some work https://github.com/damoebius/haxe-npm/issues/5 but you never did it, you never commited anything.

I told you that i don't care about my work and i want the best for people even if i should give up my module for yours.

Are you really asking for some respect ???

clemos commented 8 years ago

I have been raising criticism about this package for 1 year, as documented in issue #5. At first, it was only about removing unneeded/out-of-scope features (externs and bootstrap) from the package. As stated in the issue, despite having access to your repo, I wouldn't take the responsability to remove features that you or your users might be using.

In september, I really needed a package with haxelib and custom haxe version. We (with lexoyo) quickly reviewed your package again then, saw it still had the unneeded features, but none of the features we wanted. We reported these problems in issue #5 and #11.

That's when I decided to start experimenting on an alternative package in a separate/personnal repo: there was no progress on yours, and I didn't have the time or envy to do the cleaning on your project. I informed you in october that I had an alternative package working, and that I needed help to test it. Instead of helping me, you integrated parts of it to your package, and then asked me to test your new package, while it still didn't have the features I needed.

And then there was this https://github.com/damoebius/haxe-npm-lib/issues/1 This one really annoyed me even more...

All in all, I'm sorry if I hurt you, but I think we need to solve all this urgently.

damoebius commented 8 years ago

Ok, can i call you to talk about it ?

damoebius commented 8 years ago

According our phone call we have to :

Agree ?

clemos commented 8 years ago

Yep.

damoebius commented 8 years ago

Tell me when you publish the haxe-dev module

clemos commented 8 years ago

Thanks for the access :) I hadn't understood you meant haxe-dev was another separate npm package. How about publishing my package on haxe under a dev or beta tag (https://docs.npmjs.com/cli/dist-tag) ?

damoebius commented 8 years ago

Because it seems that you cannot version un tag. So if you need to update the dev version, it could be difficult.

As you want

Le 15.03.2016 14:03, Clément Charmet a écrit :

Thanks for the access :) I hadn't understood you meant haxe-dev was another separate npm package. How about publishing my package on haxe under a dev or beta tag (https://docs.npmjs.com/cli/dist-tag) ?

You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/damoebius/haxe-npm/issues/12#issuecomment-196807224

clemos commented 8 years ago

I published it here, for testing purposes (I'm pretty new to npm publishing...) : https://www.npmjs.com/package/haxe-dev I'll give tags a try to see if haxe@next would be a good option.

damoebius commented 8 years ago

Perfect, i'll test it as sson as possible on one of our project. Don't forget to push sources on the dev branch (or not ? )

clemos commented 8 years ago

Ok I've added the repository field. Using tags on haxe seems like a good option. From what I understand, an npm tag is pretty much like a "channel", and you can publish successive versions to it. So I guess publishing it to haxe@next or something would be nicer than haxe-dev. Let me know if it's ok for you.

damoebius commented 8 years ago

Ok, but how target a specific version of @next ?

clemos commented 8 years ago

The package.json's version field is still valid: For example, if latest is 0.0.5 and next has 0.0.6, 0.0.7 and 0.0.8, one can : npm install haxe => 0.0.5 npm install haxe@next => 0.0.8 npm install haxe@0.0.7 => 0.0.7

damoebius commented 8 years ago

Agree so if you publish a new version on haxe@next i'll get npm install haxe@next => 0.0.9 without the ability to go back to next 0.0.8 ?

clemos commented 8 years ago

Yes, you will be able to install haxe@0.0.8