Closed poshcoe closed 5 years ago
@poshcoe I've had a couple of issues with your latest commit. At a first glance it looked fine to me, but once I started working, there were issues right away. Mostly:
Anyway, I have fixed some stuff and rewrite some stuf to the old concept. Here is what&why:
For (hopefully) further participation:
openOCDPath
to openOcdPath
.Thank you!
Hi, I've made some notes about your changes.
I agree about better communication before major changes, but maybe the approach from my end would be improved by breaking this pull request up into smaller changes to focus on.
1 ... some function could be added to ignore variables in the file that are no longer applicable to this version ... If different version of ideScripts are changing 'toolsPaths.json/buildData.json' on each run, user would always have to update paths while changing from one project to another, if he doesn't (or for some reason doesn't want to) update ideScript folder and just wish to continue with work. I think that if changes to variables/file syntax is changed (should be avoided), better approach would be to introduce versioning - data for ideScripts v1 would have its own container, v2 its own, ... OR, just create new variable, but this could clutter code/file as ideScripts evolves.
2 ... Though I understand this wasn't working just yet. ... This could totaly work if all '.svd' files would be in one folder. But, as the simplest way for user is to just download package from Keil and extract it in common folder, path to common SVD folder can't be inside one extracted package, since it might be different for other project. Anyway, the alternative which I didn't think of yesterday :(, would be to cache path were all extracted SVD packages are placed and some algorithm would than search and list all '.svd' files. It is still possible to implement it, but I would wait a little bit, since I don't find this an issue. Another idea, maybe when searching for config files (OpenOCD/SVD), default paths could be recommended - user can than quickly copy&paste&navigate to that folder and get exact path.
3 OpenOCD is powerful as a single tool for using multiple interfaces, we should take advantage of that! Totaly agree with that. The problem I see is that different interfaces needs different VS Code launch/tasks/workspace configurations. It is not enough to just pass configuration files. As currently only stlink is implemented, I think it is fine to cache it. Anyway, If there will be more users that would need other interface support, we can still implement it later.
4 ... by breaking this pull request up into smaller changes to focus on... Oh, that is right. I will do my best.
Hi, first of all - love the project.
Over the last few days I've been working on some improvements to the scripts, largely to do with cross-platform support. Here's the breakdown: