damoiser / qr-bills

Ruby Gem to generate QR-Bills for Swiss payments
BSD 3-Clause "New" or "Revised" License
21 stars 15 forks source link

Could we remove the rake requirement in gemspec? #12

Closed RandieM closed 3 years ago

RandieM commented 3 years ago

Hey there,

I have the following issue, when deploying my app via Gitlab CI/CD:

Fetching gem metadata from https://rubygems.org/.........
Fetching https://github.com/damoiser/qr-bills.git
[!] There was an error while loading `qr-bills.gemspec`: cannot load such file -- rake. Bundler cannot continue.
 #  from /builds/<REMOVED_SENSITIVE_INFO>/vendor/bundle/ruby/3.0.2/ruby/3.0.0/bundler/gems/qr-bills/qr-bills.gemspec:1
 >  require 'rake'

Basically, the problem is that rake is required in qr-bills' gemspec, but it is not yet present in the Docker container, where my app is being built. I could, of course, configure Docker to include rake in all my containers, but I think it would be cleaner to adapt the code so that the rake dependency can be removed.

According to https://guides.rubygems.org/specification-reference#files, there is an alternative way of including directories and I am already using this in my fork of the qr-bills gem. Would you be willing to consider this change? If yes, I have subbmitted a PR (#13).

Many thanks!