damoiser / qr-bills

Ruby Gem to generate QR-Bills for Swiss payments
BSD 3-Clause "New" or "Revised" License
21 stars 15 forks source link

chores: tiny refactoring #6

Closed alexanderadam closed 3 years ago

alexanderadam commented 3 years ago

This is a very tiny refactoring. Also this removes setting I18n.default_locale (therefore this should fix #2). No gem should ever do that! Please set locale defaults in your application instead and don't mess with user settings.

Also the Gem modules should be scoped within a proper namespace and you don't have to use instance variables in specs. Use let instead. And you don't need RSpec.configure in every spec file. Hooks like before are available within a describe block. You can see here an example. So I guess there are still enough things to do. 😉 But the gem is working, which is great. 👍

Also you can ask me anytime in case you need feedback or some help.

Apart from the few refactoring things png is now supported as a direct output format. 😉