search

damonge / CoLoRe

CoLoRe - Cosmological Lofty Realizations
GNU General Public License v3.0
17 stars 13 forks source link

FFTW_LIB and LIB_FFTW in Makefile #48

Closed andreufont closed 4 years ago

andreufont commented 4 years ago

I noticed that in the Makefile you currently have FFTW_INC FFTW_LIB but also later on you define LIB_FFTW Are they both necessary?

Also, I noticed that LIB_FFTW add twice the standard library:

endif #SINGLE_PRECISION LIB_FFTW += -lfftw3

for fftlog

LIB_FFTW += -lfftw3

It is a minor issue (the code compiles fine), but I thought we could use the current cleanup phase :-)

damonge commented 4 years ago

Yes, both are necessary. FFTW_LIB is basically the directory where the FFTW libraries are to be found (e.g. -L/home/andreufont/software/lib/), LIB_FFTW is a list containing all the FFTW libraries that are needed (e.g. -lfftw3 -lfftw3_omp -lfftw3_mpi).

Thanks for noticing the fftlog issue. I just fixed this in #50

andreufont commented 4 years ago

Great, I'll close the ticket then.