damongolding / immich-kiosk

Immich Kiosk is a lightweight slideshow for running on kiosk devices and browsers that uses Immich as a data source.
GNU Affero General Public License v3.0
532 stars 19 forks source link

Setting show_progress: true in the config.yaml produces fatal error "Immich Url is missing" #68

Closed EricSoldierer closed 2 months ago

EricSoldierer commented 2 months ago

Describe the bug As soon as the line show_progress: true is added to the config.yaml file, the server wont start and logs show a fatal error Immich Url is missing. Uncommenting or removing only this line solves the error.

To Reproduce Steps to reproduce the behavior:

  1. Have a config.yaml file without show_progress
  2. add show_progress: true
  3. restart service
  4. read logs

Your Kiosk version 0.8.0

Your Kiosk installation

damongolding commented 2 months ago

That sounds really odd. I will have to run a test when I'm back behind my computer.

damongolding commented 2 months ago

I can't reproduce this issue I'm afraid

EricSoldierer commented 2 months ago

Hm, let me share my setup.

This is the config file I use:

immich_api_key: "XXXX"
immich_url: "http://{IMMICH_URL}:3001"

show_time: true # true or false
time_format: 24 # 12 or 24

show_date: true # true or false
date_format: DD.MM.YYYY

refresh: 60 # in seconds
disable_screensaver: true

#album: # ID(s) of album or albums to display
#  - ""
#person: # ID(s) of person or people to display
#  - ""

#show_progress: true
disable_ui: false # this is just a shortcut for all ui elements (show_time, show_date, show_image_time, show_image_date)
hide_cursor: false # Hide cursor/mouse via CSS.
background_blur: true # display a blurred version of image as background
transition: none # cross-fade, fade or none

show_progress: false # display a progress bar
image_fit: contain # how the image fits the screen. Options are none, contain and cover

# Image METADATA
show_image_time: false # true or false
image_time_format: 24 # 12 or 24

show_image_date: true # true or false
image_date_format: DD.MM.YYYY
show_image_exif: false
show_image_location: true

# options that can NOT be changed via url params
kiosk:
  password: ""
  cache: true

And this part of my compose file for all the immich stuff:

services:
  immich-kiosk:
    image: damongolding/immich-kiosk:latest
    container_name: immich-kiosk
    networks:
      ipvlan8:
        ipv4_address: {KIOSK_IP}
    tty: true
    environment:
      TZ: "Europe/Berlin"
    volumes:
      - ./kiosk/config.yaml:/config.yaml
    restart: always

Issue still persists. When I uncomment #show_progress: true the server no longer starts and complains about a missing URL.

damongolding commented 2 months ago

Ok so I can reproduce the error by uncommenting #show_progress: true.

The issues is cause because you have two show_progress entries. One at line 18 and one at 24.

Delete one and then set the other to your desired option (true | false)

EricSoldierer commented 2 months ago

Oh wow.. thanks man