search

damonhook / aos-statshammer

A tool for calculating and comparing damage outputs for Warhammer Age of Sigmar units.
https://aos-statshammer.herokuapp.com/
MIT License
18 stars 10 forks source link

Bugs with Damage Calculation for Mortal Wounds #71

Closed Likewise42 closed 3 years ago

Likewise42 commented 3 years ago

Hello! I was messing around with stats hammer and noticed some inconsistencies with averages.

These inputs give me outputs that degrade when you increase the save which is not right. image image

And these inputs are mathematically equivalent, yet result in different outputs. image

On chrome 92.0.4515.107/Windows if that helps!

sedulam commented 3 years ago

I'm getting the same behavior. I'm trying to replicate the Huskard on Thunderthusk's Blood Vulture: image

damonhook commented 3 years ago

So what I believe is happening is the follows: After calculating the number of hits resulted in mortal wounds, it then has to deduct that from the number of normal (non MW) hits (since it is not "in addition").

Where this becomes an issue is when the chance to get a MW is higher than the base hit chance (thus more MW hits than normal ones). So when the deduction happens, it lands up doing negative hits.

TLDR: It should be an easy enough fix, just need to put a lower bound to the deductions.

damonhook commented 3 years ago

I have rolled out a fix in version 2.1.5

Screenshot 2021-08-11 at 15 05 27