search

damonitor / damo

DAMON user-space tool
GNU General Public License v2.0
8 stars 2 forks source link

Hiding quotas and watermarks when unused in fmt_json #10

Open sj-aws opened 1 month ago

sj-aws commented 1 month ago

For continuing discussions from https://github.com/awslabs/damo/issues/104

sjp38 commented 2 weeks ago

@honggyukim , I'm waiting for answer to below question. No rush. Just reminding and making the status clear.

Thank you for the clarification. And I agree those can be hidden, and that will make the output short. But, I'd like to further understand what is the problem of the current long output, and why.

For example, do you need to read and modify the output, and doing so with long output is painful? Why? Due to absence of existing tools that optimized for that? Due to your special workflow? What tool you use, what kind of modifications and reading you do for what?

We can definitely make the change, but it will impose some complexities in my opinion. I'd like clearly understand if the benefit of the change really outweighs the increase of complexity.

(https://github.com/awslabs/damo/issues/104#issuecomment-2278362029)

honggyukim commented 2 weeks ago

We can definitely make the change, but it will impose some complexities in my opinion. I'd like clearly understand if the benefit of the change really outweighs the increase of complexity.

I think the current unused quotas and watermarks info rather increase complexity for general users. Why not hiding them to make the json or yaml output compact and concise?