search

damonkohler / sl4a

SL4A brings scripting languages to Android by allowing you to edit and execute scripts and interactive interpreters directly on the Android device.
Apache License 2.0
2.42k stars 803 forks source link

Interpreter installer ignores already downloaded packages. #177

Open damonkohler opened 9 years ago

damonkohler commented 9 years ago

From @GoogleCodeExporter on May 31, 2015 11:28

As I'm behind a proxy, I tried to download an interpreter on my computer and 
install it from the phone's sdcard.

Following the faq, I should be able to download an interpreter and put the zip 
files on my sdcard, so the interpreter installer do not have to download it. ( 
see http://code.google.com/p/android-scripting/wiki/InstallingInterpreters)

After trying to get it working, I found out that the current code does not look 
for files located in /sdcard/ as stated in the FAQ. The current installer 
downloads file in /sdcard/<interpreter package> (example for python: 
/sdcard/com.googlecode.pythonforandroid/).

So, I tried to put the zip file there like:
/sdcard/com.googlecode.pythonforandroid/python_r7.zip
/sdcard/com.googlecode.pythonforandroid/python_scripts_r8.zip
/sdcard/com.googlecode.pythonforandroid/python_extras_r8.zip

But it does not work. After some more investigations, 
com/googlecode/android_scripting/InterpreterInstaller.java was changed in 
revision 4759ec78d9 to delete the download folder before trying to install the 
files.

Can the code be changed so that the download folder is kept if it exists when 
the installer launches ?

(this will also be a workaround for issue #187)

Original issue reported on code.google.com by oli.sa...@gmail.com on 12 Jan 2011 at 9:56

Copied from original issue: damonkohler/android-scripting#503