damonlynch / rapid-photo-downloader

Rapid Photo Downloader is the leading photo and video downloader for the Linux desktop.
https://damonlynch.net/rapid
GNU General Public License v3.0
109 stars 29 forks source link

ORF Preview for OM-5 is not working (Pen E-P5 was working) #183

Closed alexbarcelo closed 3 months ago

alexbarcelo commented 3 months ago

I have been using RPD with ORF raws and it is able to show me preview for .ORF raws shot with an Olympus Pen E-P5

However, now that I had some raws from a OM Systems OM-5, the preview is not working.

I have high suspicions that the issue is related to the MakerNote proprietary blob, my investigation shows that EXIF MakerNote has a 1.5MB of binary field with magic numbers b'OM SYSTEM\x00\x00\x00II'. That was me playing around with exifread python library just for exploration. The exiftool command (version 12.40) works with the Pen E-P5 (exiftool -b -ThumbnailImage <path_to_ORF> but, with the OM-5 raw, it complains with the following and yields no data:

Warning: [minor] MakerNotes tag 0x2010 IFD format not handled - <path_to_ORF>

I may be completely off-track, as I realistically have no idea what I'm doing. If it is a solved issue, I missed how to fix my workflow. If it is not supported, I am happy to provide provide more info / help / give samples / investigate / etc. (probably the thumbnail generation is offloaded to another library, but I haven't yet investigated RPD internals on thumbnail generation).

alexbarcelo commented 3 months ago

I am dumb. I thought that I had tried it with several Ubuntu versions, but I had only tested Ubuntu 22.04 (my daily drive). This issue is solved with Ubuntu 23.10, maaaybe it is related to https://github.com/Exiv2/exiv2/issues/2126 and is something that has been addressed on 2022 seeing the timestamp of the comments there.

My confusion arose from me checking also the Nautilus thumbnail, which never works with ORF (it seems to be related to gdk-pixbuf-thumbnailer, but that is completely off topic here). Those tests confused my troubleshooting and my memory played tricks on me.

The issue with OM-5 (and I suppose also OM-1 and current/future OM System bodies) is solved just by upgrading the system. 22.04 does not work (maybe backporting packages would help)... but being April, I will wait for a few weeks and plan an upgrade to LTS 24.04