search

dampee / ImageProcessor.Plugins.Pdf

A PDF fileformat for ImageProcessor
MIT License
15 stars 10 forks source link

Allow to override default rasterizer DPI parameters #5

Closed turowicz closed 6 years ago

turowicz commented 7 years ago

Needed to get better rendering results for text documents.

Related #3

turowicz commented 7 years ago

@dampee please review :)

dampee commented 7 years ago

Hi, It seems you have not done any change to the PdfRasterizer class. Could you update so that the file does not appears to be changed in the pull request? Kind regards Damiaan

turowicz commented 7 years ago

It had incorrect line endings, that's why you don't see any difference in diff.

Will revert it. I've also noticed some other problems with how ImageProcessor instantiates PdfFormat... Will submit some new changes tomorrow.

dampee commented 7 years ago

Cool, thans! Please keep different issues in different PR's.

Op 17 jul. 2017 9:39 p.m. schreef Wojtek Turowicz notifications@github.com:

It has incorrect line endings, that's why you don't see any difference in diff.

Will revert it. I've also noticed some other problems with how ImageProcessor instantiates PdfFormat... Will submit some new changes tomorrow.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/dampee/ImageProcessor.Plugins.Pdf/pull/5#issuecomment-315859649, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABxXtBGZbUgDKb-HUh5D8TfynbZNn1rzks5sO7hcgaJpZM4OZ5B1.

turowicz commented 7 years ago

@dampee I've reverted the line endings. Strange that you keep one file in CR and another CRLF but that's up to you.

I've also changed the constructor of PdfFormat as it needs to be parameterless, otherwise ImageProcessor throws exceptions.

Hope this is good enough, thanks!