search

dams-mcda / Dams-MCDA

Emma Fox R/Shiny Project with a docker server configuration
1 stars 0 forks source link

Revert "simplified score summing in WSM_graphs_test" #114

Closed elbfox closed 4 years ago

elbfox commented 4 years ago

Reverts dams-mcda/Dams-MCDA#113. I was hasty in my review, and I don't necessarily think we need to revert this whole thing, but I did want to offer it as an option and this seemed like a good way to highlight the section of code I'm talking about...

Problem: lines 16 - 323 (current version) don't do what they're supposed to do. The sum is for each dam, and not for each decision alternative for each dam. The individual scoresum* values in lines 309-375 (reverted version) are used to graph each dam's decision alternative MCDA scores (sums) in isolation. Currently, the sum procedure only generates one sum value per dam, whereas before (reverted version) it generated 5 values per dam.

sythel commented 4 years ago

oops, yeah i see the problem, easy fix

sythel commented 4 years ago

lets put this PR on hold and Ill make a new one with fixes

elbfox commented 4 years ago

Excellent, thank you.

sythel commented 4 years ago

closing, resolved in #115