search

dams-mcda / Dams-MCDA

Emma Fox R/Shiny Project with a docker server configuration
1 stars 0 forks source link

TabsUpdate_Dams graphics issues WW #92

Closed elbfox closed 4 years ago

elbfox commented 4 years ago

Graphic issues in this branch need to be resolved. I think I may have confused the flow of the buttons by adding additional results tabs for the updated structure. @sythel could you please look over the new tabs for input/output flow?

Results tabs for each dam is supposed to have 3 graphs (so far) to depict results calculated the same way as in http://shiny.gsscdev.com/dams_mcda/ (again, so far) see server.R, ui.R

ALSO: Step1 tab has over-sized image of fish (not sure how to cut this down...) see ui.R

sythel commented 4 years ago

fixed image by adding width attribute

sythel commented 4 years ago

removed

Please login with a username (email address) and a password.

due to the new layout will require login before they reach thispage

sythel commented 4 years ago

I see 8 enter preferences tabs and 8 results tabs. I don't see the problem mentioned.

elbfox commented 4 years ago

Slider input doesn't create graphic output, from what I can tell in my local test version of the app. I'm just running the app without the server for testing. The output tabs are there but the results graphs don't appear (even if they would be wrong, at this stage). Do they appear for you?

Also, I did some work on this after I highlighted the issue and may have commented out the fish image because it was distracting, but it should still be in the code. When you run the script, the fish image shows up HUGE in the first tab.

sythel commented 4 years ago

image fixed see comment or commit reference above

sythel commented 4 years ago

are lines 588-606 still needed? @elbfox

elbfox commented 4 years ago

Potentially. I kept them in because I thought we would need to refer to the decision alternatives separately in printing the results graphs. Sam Roy sent a zip file with 3D matrix changes that I need to review and commit, so I'll take the lines out if he calls the alternatives some other way.

sythel commented 4 years ago

will need to revert the removal of https://github.com/dams-mcda/Dams-MCDA/commit/9de516d2ff5ad49b73e39e093ea93b391c48ee61#diff-808283fc76a538e4aaeb6138cb9e5f71L36 server.R line 36, I will do it in my branch

sythel commented 4 years ago

update buttons and progress now working again, will look into results next

elbfox commented 4 years ago

thank you!

sythel commented 4 years ago

error in server.R

Warning: Error in unlist: object 'r' not found shiny_server_1 | 74: unlist shiny_server_1 | 73: generateOutput [/srv/shiny-server/dams_mcda/server.R#746] shiny_server_1 | 72: observeEventHandler [/srv/shiny-server/dams_mcda/server.R#1669] shiny_server_1 | 1: runApp

r is not defined here

elbfox commented 4 years ago

lines 588- 606 can be commented out for now

sythel commented 4 years ago

if I change r to q in the quoted link:

Warning: Error in data.frame: row names supplied are of the wrong length

seems that the for loop needs debug/fixing

error in server.R

Warning: Error in unlist: object 'r' not found shiny_server_1 | 74: unlist shiny_server_1 | 73: generateOutput [/srv/shiny-server/dams_mcda/server.R#746] shiny_server_1 | 72: observeEventHandler [/srv/shiny-server/dams_mcda/server.R#1669] shiny_server_1 | 1: runApp

r is not defined here

sythel commented 4 years ago

dam 2d array values fixed in next commit.

generate output seems to have problems with data and graphs

sythel commented 4 years ago

@elbfox

Results tabs for each dam is supposed to have 3 graphs

graph1: same as before but only for dam instead of alternative (shows raw scores) graph2: same as before but only for dam instead of alternative (shows total raw score composition) graph3: graph with WSM scores? one dam or all dams?

edit: Making assumptions based upon current plot names: graph1 (SummPlot#) will be as stated before and graph 2,3 will be WSM related. new questions: Will there be a graph containing all dams on each dam results? or will we need to add another results page/tab for the collective results?

also I am moving the raw score graph logic outside of the "generateOutput" logic to clean things up

elbfox commented 4 years ago

Hi, graphs description quoted in Task 13.

There will be a "multi-dam" results tab with the WSM results for all dams (after Sam's MOGA code, which looks at all dams in the 3d matrix. I haven't added this yet. I am going to spend time on this tomorrow.

elbfox commented 4 years ago

I am getting this error when I try to run the app for testing: Warning: Error in : No handler registered for type .clientdata_output_Step 1: Start Here_hidden Stack trace (innermost first): 1: runApp Error in (function (name, val, shinysession) : No handler registered for type .clientdata_output_Step 1: Start Here_hidden

I don't know that output this means because Step 1 is just text and the fish image right now

sythel commented 4 years ago

fixed in master

sythel commented 4 years ago

think it has to do with htmlOutput tag

elbfox commented 4 years ago

thank you! I'm still struggling with understanding the input/output connection in Shiny.