search

damus-io / api

damus api
3 stars 3 forks source link

Downed lightning node can take down our API #5

Open jb55 opened 5 months ago

jb55 commented 5 months ago

This one is a bit more serious than

My lightning node is down due to disk corruption, I noticed someone tried to subscribe/renew and it took down the api:

Apr 13 18:34:00 purple damus-api[3191304]: [ GET ] /ln-checkout/66a5a0d3-d896-456c-b823-55d61f8587ab: 200                            
Apr 13 18:34:00 purple damus-api[3191304]: node:events:495                                                                           
Apr 13 18:34:00 purple damus-api[3191304]:       throw er; // Unhandled 'error' event                                                
Apr 13 18:34:00 purple damus-api[3191304]:       ^                                                                                   
Apr 13 18:34:00 purple damus-api[3191304]: Error: connect ECONNREFUSED 24.86.66.39:9735                                              
Apr 13 18:34:00 purple damus-api[3191304]:     at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1555:16)                     
Apr 13 18:34:00 purple damus-api[3191304]: Emitted 'error' event on Socket instance at:                                              
Apr 13 18:34:00 purple damus-api[3191304]:     at emitErrorNT (node:internal/streams/destroy:151:8)                                  
Apr 13 18:34:00 purple damus-api[3191304]:     at emitErrorCloseNT (node:internal/streams/destroy:116:3)                             
Apr 13 18:34:00 purple damus-api[3191304]:     at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {      
Apr 13 18:34:00 purple damus-api[3191304]:   errno: -111,                                                                            
Apr 13 18:34:00 purple damus-api[3191304]:   code: 'ECONNREFUSED',                                                                   
Apr 13 18:34:00 purple damus-api[3191304]:   syscall: 'connect',                                                                     
Apr 13 18:34:00 purple damus-api[3191304]:   address: '24.86.66.39',                                                                 
Apr 13 18:34:00 purple damus-api[3191304]:   port: 9735                                                                              
Apr 13 18:34:00 purple damus-api[3191304]: }                                                                                         
Apr 13 18:34:00 purple damus-api[3191304]: Node.js v18.19.0

let's maybe harden this a bit!