search

damus-io / damus

iOS nostr client
GNU General Public License v3.0
2k stars 289 forks source link

NavigationStack: prevent nested navs #1401

Open jb55 opened 1 year ago

jb55 commented 1 year ago

There are multiple places where navigation is getting pushed infinitely:

  1. Hashtags

  2. Profile pics

A simple solution to this would be to check to see if the same route you're pushing is already at the top of the navigation stack and then prevent it.

alltheseas commented 1 year ago

This is the solution to infinite hashtag rabbit hole

https://github.com/damus-io/damus/issues/1367

alltheseas commented 1 year ago

And infinite profile rabbit hole

https://github.com/damus-io/damus/issues/104

brett-doffing commented 1 year ago

I can take this on. @alltheseas

alltheseas commented 1 year ago

I can take this on. @alltheseas

Assigned 💪

alltheseas commented 1 year ago

@brett-doffing I invite you to the Damus team. If you accept, are you able to self-assign tickets?

brett-doffing commented 1 year ago

I am not able to self-assign @alltheseas

jb55 commented 1 year ago

I added the dev team to the project page so everyone should be able to self-assign now

brett-doffing commented 1 year ago

Still a no-go on my end.

alltheseas commented 1 year ago

Still a no-go on my end.

Hmm. Do you want me to re-assign you in meanwhile?

image

brett-doffing commented 1 year ago

Please do. I was just trying to test it out.