damus-io / damus

iOS nostr client
GNU General Public License v3.0
2k stars 289 forks source link

Unfollow does not work (npubs I dont follow appear on my feed) #1483

Open alltheseas opened 1 year ago

alltheseas commented 1 year ago

what happens When I unfollow someone, their reposts keep appearing in my timeline. I don't follow the hashtag in their profile either. Closing, and reopening does not work.

I just noticed the issue hasn’t left, notice how it says reposted and it’s inside the feed and I don’t follow the npub

https://github.com/damus-io/damus/assets/64376233/71a69e7c-1669-4722-94c3-2b6bdddf55c7

origin: sersleepy

alltheseas commented 1 year ago

image

Reported by Gek

alltheseas commented 1 year ago

Potentially related to following, and unfollowing

https://damus.io/note1cw4ycku76w0lfjuj5urlaj9sf79kza9943m9tjfcxfclszedue8qwy57y9

alltheseas commented 1 year ago

Related: unfollow requires close and re-open https://github.com/damus-io/damus/issues/942

jb55 commented 1 year ago

On Fri, Sep 29, 2023 at 12:52:15PM -0700, alltheseas wrote:

Related: unfollow requires close and re-open https://github.com/damus-io/damus/issues/942

this should be fixed though... we should make sure which version this report is coming from

alltheseas commented 1 year ago

On Fri, Sep 29, 2023 at 12:52:15PM -0700, alltheseas wrote:

Related: unfollow requires close and re-open https://github.com/damus-io/damus/issues/942

this should be fixed though... we should make sure which version this report is coming from

Latest testflight build and 17.0.1

jb55 commented 1 year ago

On Fri, Sep 29, 2023 at 01:34:39PM -0700, alltheseas wrote:

On Fri, Sep 29, 2023 at 12:52:15PM -0700, alltheseas wrote:

Related: unfollow requires close and re-open https://github.com/damus-io/damus/issues/942

this should be fixed though... we should make sure which version this report is coming from

Latest testflight build and 17.0.1

can we confirm this isnt a followed hashtag?

alltheseas commented 1 year ago
Screenshot 2023-10-11 at 10 54 26 AM

@jb55 I double checked gek's followed hashtags - he has none.

kristapsk commented 12 months ago

I have the same issue. Damus 1.5 (8) under iOS 15.

alltheseas commented 10 months ago

Additional report by sleepy

https://t.me/damusdev/6132

Have you guys had an issue with seeing notes from npubs you don’t follow, or nobody you follow renotes, yet still shows up on your feed ? it’s been happening a lot lately did something change or

Unfollowed these npubs many many weeks ago

https://github.com/damus-io/damus/assets/64376233/67fd6685-2f08-40ec-94f8-efa258909287

alltheseas commented 9 months ago

@kernelkind I just recreated this using the following npub:

npub1ae82lwzuy739fld0z2u3dr7uxlvh7tgfr8vhr3wcy94rw5v0skgqkuqzlr

https://njump.me/nprofile1qqswun40hpwz0gj5lkh39wgk3lwr0ktl95y3nkt3chvzz63h2x8ctyqpz3mhxue69uhhyetvv9ujuerpd46hxtnfduq3jamnwvaz7tmsw4exzanfv3sjumn0wd68ytnvv9hxgqgdwaehxw309ahx7uewd3hkcqgcwaehxw309aex2mrp0yhxummnw3ezucm0d5hxzagmtcxv7

alltheseas commented 8 months ago

report of unfollowed hashtag keeps appearing

https://damus.io/nevent1qqs8ff88vvw9sr2w0skfdmt79uhkzmls49k6xd66q78uwu06mfu057spzdmhxue69uhhqatjwpkx2urpvuhx2ue0qythwumn8ghj7un9d3shjtnswf5k6ctv9ehx2ap0qyv8wumn8ghj7un9d3shjtnrw4e8yetwwshxv7tf9uq3yamnwvaz7tmsw4e8qmr9wpskwtn9wvjtuzss

alltheseas commented 7 months ago

Unfollowed hashtag clears posts after damus app close, and re-open

alltheseas commented 7 months ago

https://github.com/damus-io/damus/issues/1747#issuecomment-1876916938

alltheseas commented 7 months ago

https://damus.io/nevent1qqsxjtd4xwadsf0ucz86ed3rgf6pafvyewq4fm507skl6fccp27tjfgr648gc

alltheseas commented 6 months ago

https://damus.io/nevent1qqsfsa943yjeq5w9nl4n63vld8sajn73lkmuwxklw8dhv8ejy9enslcprfmhxue69uhkummnw3ezummjv9hxwetsd9kxctnyv4mqz9nhwden5te0wfjkccte9ec8y6tdv9kzumn9wsq3gamnwvaz7tmjv4kxz7fwv3sk6atn9e5k7qgkwaehxw309aex2mrp0yhxummnw3ezucnpdejqpatzh2

alltheseas commented 6 months ago

@danieldaquino mystery detective work (bonust points for current sprint)

alltheseas commented 6 months ago

semisol asks:

Do you purge non-followed posts from the timeline when you get a newer revision of the contact list?

Because most likely 1 relay has an outdated list, it sends it, those notes enter the timeline Semisol says:then the actual contact list arrives but it still stays

alltheseas commented 5 months ago

Issue seems to persist

https://damus.io/nevent1qqstr6zstcmypwrtx08sf8del05qpqlql43zeu2gaaj04q2fnnlhh6cpzdmhxue69uhkvun9v4ex2mrp0yh8s7t6qyg8wumn8ghj7mn0wd68ytnhd9hx2qgdwaehxw309ahx7uewd3hkcqg4waehxw309a5x7mred3sk6c3wdahxc6twv5g54d97

I finally took your advice and signed out and back in to Damus. Still seeing posts from people I’ve unfollowed.

alltheseas commented 3 months ago

Issue persists for me - seeing a npub I unfollowed in my feed. No hahstags in the note

hodlrodeo commented 2 months ago

Another occurrence of this issue (version 1.9.1)

When I unfollow someone on Damus, the posts continue to show in my “follow” feed. Is this something that eventually refreshes or stops happening? I’ve ended up having to mute users I only want to unfollow (and still see posts from in the broader search) #asknostr #damus

https://damus.io/nevent1qqsgc797gmg5j0v0kwn33ngvk9gfkuan4zccek046ghpkfktatp3wlcpzfmhxue69uhhqatjwpkx2urpvuhx2ucpr3mhxue69uhkummnw3ezumt4w35ku7thv9kxcet59e3k7mgpr3mhxue69uhkummnw3ezucnfw33k76twv4ezuum0vd5kzmqpzemhxue69uhhyetvv9ujumn0wd68ytnzv9hxgswyvs0

alltheseas commented 2 months ago

@hodlrodeo did you try closing damus app, and re-opening after an unfollow?

hodlrodeo commented 2 months ago

@hodlrodeo did you try closing damus app, and re-opening after an unfollow?

I did- I have fully closed the app and reopened several times over a few days and unfollowed users posts still appear in my feed

alltheseas commented 2 months ago

Got you boss

hodlrodeo commented 2 months ago

Got you boss

Fwiw I have not noticed these posts from unfollowed users in my feed in the past week.

alltheseas commented 2 months ago

@danieldaquino @jb55 do yall think it was something nostrdb related?

@hodlrodeo did you clear cache, or reinstall the app?

hodlrodeo commented 2 months ago

Neither - I continued use as normal. I close the app completely on at least a daily basis. Version 1.9.1 iOS

jb55 commented 2 months ago

there are two issues: