Open danieldaquino opened 10 months ago
Noticed that the main Purple screen in iOS has visual issues on dark mode. I am adding that to the acceptance criteria of this ticket.
I have a commit that fixes all except for MacOS/iPad optimization (I can't figure out how to run the simulator without an apple dev account)
I have a commit that fixes all except for MacOS/iPad optimization (I can't figure out how to run the simulator without an apple dev account)
Thanks @kernelkind!
No worries about the MacOS/iPad optimization, we can split it into a separate ticket.
@jb55, @alltheseas, with @kernelkind's changes, and with my changes in #1899, we hit almost all of the acceptance criteria of this ticket.
The only thing not crossed off the list is iPad/macOS screen optimization. But as we discussed in the standup, it might not be necessary for Wednesday's release.
We can probably close this once #1899 gets merged in and if we create a ticket for iPad/macOS screen optimization, targeted post-wednesday-release
@danieldaquino proposes to add sheetview for larger screens
@alltheseas, @jb55, just checked how the LN flow looks like on iPad. It's not perfect, it could definitely use some tweaks, but looks "passable" enough that does not require an urgent fix (in my opinion).
I would say the remainder of this task looks low effort (not hard to fix), and medium-low priority.
Here are the screenshots I took:
Damus version: Current tip of master (da82663634ae269776b0778be399abd29e650c1d
)
Screenshots:
Please let me know what you think!
Thanks Daniel.
My suggestion is to have at iOS IAP as most important, and to follow the rest of the Madeira milestone items 🙏
Not terrible, not great.
defer
As of writing, the Damus Purple UI draft has some rough edges. Namely:
Note: This ticket can be broken down further if necessary
Development notes
To access experimental Purple feature, please follow these guidelines: