damus-io / damus

iOS nostr client
GNU General Public License v3.0
2k stars 289 forks source link

Purple iPad design (formerly Damus Purple: Polish UI/UX flow) #1847

Open danieldaquino opened 10 months ago

danieldaquino commented 10 months ago

As of writing, the Damus Purple UI draft has some rough edges. Namely:

  1. [x] A portion of the screen is missing the gradient background (See (1) in figure below)
  2. [x] Scrolling down reveals an unappealing navigation bar (See (2) in figure below)
  3. [x] After subscribing, the user is shown a "welcome" sheet. However, dismissing the sheet takes the user back to the Damus purple signup screen. This flow needs to be improved. It should probably take them back to the home feed. Alternatively, we can also try to make the whole Damus purple flow happen inside a content sheet (the one that shows up from the bottom of the screen)
  4. [ ] The screens are not optimized for larger screens. (e.g. iPad or Mac).
  5. [x] Make sure visuals look the same in both light and dark mode Purple UX issues

Note: This ticket can be broken down further if necessary

Development notes

To access experimental Purple feature, please follow these guidelines:

  1. You can run this on the iOS simulator, to simplify work. That will also set you up in the Xcode development in-app purchase environment (Where no real money is spent, purchases are simulated)
  2. You need to enable the purple feature. Go to settings -> Developer settings -> Turn developer mode ON, as well as experimental purple support
  3. You will then see the "Purple" option appear on the side menu.
danieldaquino commented 10 months ago

Noticed that the main Purple screen in iOS has visual issues on dark mode. I am adding that to the acceptance criteria of this ticket.

kernelkind commented 9 months ago

I have a commit that fixes all except for MacOS/iPad optimization (I can't figure out how to run the simulator without an apple dev account)

danieldaquino commented 9 months ago

I have a commit that fixes all except for MacOS/iPad optimization (I can't figure out how to run the simulator without an apple dev account)

Thanks @kernelkind!

No worries about the MacOS/iPad optimization, we can split it into a separate ticket.

danieldaquino commented 9 months ago

@jb55, @alltheseas, with @kernelkind's changes, and with my changes in #1899, we hit almost all of the acceptance criteria of this ticket.

The only thing not crossed off the list is iPad/macOS screen optimization. But as we discussed in the standup, it might not be necessary for Wednesday's release.

We can probably close this once #1899 gets merged in and if we create a ticket for iPad/macOS screen optimization, targeted post-wednesday-release

alltheseas commented 9 months ago

@danieldaquino proposes to add sheetview for larger screens

alltheseas commented 9 months ago
danieldaquino commented 9 months ago

@alltheseas, @jb55, just checked how the LN flow looks like on iPad. It's not perfect, it could definitely use some tweaks, but looks "passable" enough that does not require an urgent fix (in my opinion).

I would say the remainder of this task looks low effort (not hard to fix), and medium-low priority.

Here are the screenshots I took:

Damus version: Current tip of master (da82663634ae269776b0778be399abd29e650c1d) Screenshots:

Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 32 20 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 27 43 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 27 56 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 32 26 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 33 48 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 33 56 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 34 08 Simulator Screenshot - iPad (10th generation) - 2024-02-09 at 10 34 24

Please let me know what you think!

alltheseas commented 9 months ago

Thanks Daniel.

My suggestion is to have at iOS IAP as most important, and to follow the rest of the Madeira milestone items 🙏

alltheseas commented 8 months ago

Not terrible, not great.

defer