search

damus-io / damus

iOS nostr client
GNU General Public License v3.0
1.95k stars 290 forks source link

Push notifications #2225

Open jb55 opened 1 week ago

jb55 commented 1 week ago

This is a tracking issue to get push notifications out the door

alltheseas commented 1 week ago

What is the dependency on waiting for permissions from apple @danieldaquino ?

alltheseas commented 1 week ago

What is the dependency on waiting for permissions from apple @danieldaquino ?

Do we have an issue for tracking the apple permissions?

@jb55 cc @danieldaquino meta-comment on issue of issues tracking: I re-arranged the issues to having the pre-requisite/mandatory tickets at the top, and the nice-to-haves and/or uncertain tickets towards the bottom. If yall agree we can carry forward this practice for issues of issues.

We can also carry forward this practice for milestones - most important issues at top, least at bottom.

danieldaquino commented 1 week ago

@alltheseas

What is the dependency on waiting for permissions from apple @danieldaquino ?

For this particular plan, none. Here is an excerpt of an email containing relevant context:

(...) we might be able to roll it out whether or not we have the Push notification filtering entitlement.

Will mentioned that we do not yet have support for encrypted mute lists (we don’t create them, and we do not parse them either).

Since we do not have support for that yet (Most mute lists on Damus are presumably public), we can perform mute filtering on the server-side based on those public lists (without worsening user’s privacy). If we do that, then having the entitlement does not make a difference until we have encrypted mute lists.

Given that state of affairs, Will mentioned it will be worth rolling out that feature regardless of whether we get the entitlement or not.

danieldaquino commented 1 week ago

most important issues at top, least at bottom.

Love it, 100% agree we should use that convention