damus-io / damus

iOS nostr client
GNU General Public License v3.0
1.99k stars 288 forks source link

Landscape to portrait full screen video player quirk #2263

Open alltheseas opened 4 months ago

alltheseas commented 4 months ago

What happens In full screen mode in note view, When I switch between landscape and portrait mode in a video, the video I'm Watching stops, and another instance plays in the background.

What I expect to happen I expect my video to continue playing if I switch from portrait to landscape mode or vice versa.

Link to noteID, npub

https://damus.io/nevent1qqstdmpnfazcqzekgmt2mxyvhv4ntuuhc5lhekjl02u7uga3m6ftquspr3mhxue69uhkummnw3ezucnfw33k76twv4ezuum0vd5kzmqppamhxue69uhkummnw3ezumt0d5q3gamnwvaz7tmjv4kxz7fwdehhxarj9e3xwqg5waehxw309aex2mrp0yhxummnw3ezucmgrvqqz0

Versions Damus version: 1.9 (6)

alltheseas commented 4 months ago

Example note

https://damus.io/nevent1qqsgpu2huyhzsxpgyczm9tkuwt6cum9u8ahmxf4q5l5wvl4c7ykwxycpk2e54

1) Go to note 2) hit unmute to play 3) tap video to go fullscreen 4) rotate to landscape 5) rotate back to portrait

alltheseas commented 4 days ago

From Arvin

Once in the post viewing the video, when turned to landscape view, boots me back out to my feed, often displaced from where I left off

https://github.com/user-attachments/assets/e78a368a-ff9e-4ea3-ad4f-b4290f4ff9fe

alltheseas commented 4 days ago

From rojo

one big I keep getting on Damus is when I’m playing a video when my phone is in portrait orientation and then switch to landscape orientation, my Damus app brings me out of the video and into the feed page. Just a big I wanted you to be aware of. Either way thank you for an all around great app.

alltheseas commented 3 days ago

landscape is used by damus customers for the following reasons:

1) reading 2) watching landscape videos 3) viewing landscape images 4) gaming ("plants vs zombies"; "oldschool runescape") 5) filming in landscape mode 6) multi-tasking

when playing oldschool runescape I'll even be watching youtube picture-in-picture. multitasking. then I switch back and forth between damus while in landscape.

sometimes it's a better layout for reading. I used to use it more when I used my phone as an emulator for games.

If I happen to be laying down for any reason, landscape is much nicer.