search

damus-io / damus

iOS nostr client
GNU General Public License v3.0
1.99k stars 288 forks source link

Bug: Zaps not showing #2356

Open rolznz opened 1 month ago

rolznz commented 1 month ago

What happens When I receive zaps to my node, they do not show in the Damus UI.

What I expect to happen I expect zaps to show.

Link to noteID, npub note1d2k8z60866a07pmxsy5rcp47jmdyskjz0n3d3tjg6dsj8l0jpd6sx2xwgt

Screenshots/video recording Damus: image

Primal Web: image

Versions Damus version: 1.9 (14) Operating system version: iOS 17.5.1 Device iPhone 11

Steps To Reproduce Steps to reproduce the behavior:

  1. Open this link in Damus: https://damus.io/nevent1qqsx4tr3d8nadwhlqangz2puq6lfdkjgtfp8eckc4eydxcfrlheqkagprfmhxue69uhhyetvv9ujumn0wd68yurvv438xtnrdakszrthwden5te0dehhxtnvdakqzynhwden5te0wp6hyurvv4cxzeewv4esz9rhwden5te0wfjkccte9ehx7um5wghxyec598npw
  2. View zaps

Additional context This seems to do with the description hash validation, which should have been fixed by https://github.com/damus-io/damus/commit/43630cbfa650f731c4843dc4acb5dcd9f792d8f0 but it does not seem to.

alltheseas commented 1 month ago

@rolznz was this the first time you saw this note? By chance did you previously zaps that disappeared?

rolznz commented 1 month ago

@alltheseas I don't understand your question. I posted this note and I tried viewing it multiple times, the zaps never show

alltheseas commented 1 month ago

@alltheseas I don't understand your question. I posted this note and I tried viewing it multiple times, the zaps never show

You answered my question. Sometimes zap appear, and later disappear on damus.