damus-io / damus

iOS nostr client
GNU General Public License v3.0
1.99k stars 288 forks source link

Feature Request: Multiple linked note support #2378

Open dmnyc opened 1 month ago

dmnyc commented 1 month ago

Current behavior: When a note contains more than one linked note, only the first one is displayed and the others are ignored and rendered only as nondescript links.

Proposed behavior: Display all linked notes inline, but truncate the post past a certain length to allow the user to expand the post to see more.

This behavior already exists on Nostur and other clients.

image image image

dmnyc commented 1 month ago

Note example:

note1et8ucs8msg92vhnx0fsmlgf3dpqd300sx2zjwdwuhffs4q3syftsk7g4jx

derekross commented 1 month ago

This would be a good feature to have. I just confirmed this behavior by checking all Nostr clients that I use and it seems that Damus is unique here. I feel that the proposed behavior is a nice compromise and provides a good user experience.

jb55 commented 1 month ago

we just do what twitter does, which has always been our baseline. I'm not against a preview carousel though.

dmnyc commented 1 month ago

Why would you ever want to do just what Xitter does, lol

dmnyc commented 1 month ago

Carousel would be great though. Anything to be more content-focused, it's a good approach.

alltheseas commented 1 month ago

Why would you ever want to do just what Xitter does, lol

Generally it's a good starting point, considering 100,000s of engineer and designer career years invested on figuring out what works reasonably.

Great feedback @dmnyc, keep it coming :muscle:

alltheseas commented 1 month ago

@ericholguin for your consideration, ser :pray:

jb55 commented 1 month ago

A few meeting notes about this:

a carousel would probably be janky with notes of different sizes. I like the "8 additional notes" thing that Nostur does, seems like a simple way to implement it.

derekross commented 1 month ago

I like it. Would love this functionality on Notedeck eventually as well. Derek Ross https://NostrPlebs.com https://NostrPlebs.com/s/derekross

On Mon, Aug 12, 2024, 1:01 PM William Casarin @.***> wrote:

A few meeting notes about this:

a carousel would probably be janky with notes of different sizes. I like the "8 additional notes" thing that Nostur does, seems like a simple way to implement it.

— Reply to this email directly, view it on GitHub https://github.com/damus-io/damus/issues/2378#issuecomment-2284508787, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAFYLSGLM5KTZOSQSVBRZWTZRDS43AVCNFSM6AAAAABMMD22Q6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBUGUYDQNZYG4 . You are receiving this because you commented.Message ID: @.***>

dmnyc commented 1 month ago

I think it just better takes into account the differences between Xitter and Nostr. On Xitter they even eliminated previews for many types of links, which ruined the user experience IMHO. Nostr has fewer constraints, and new use cases such as this are presented by users. While it can be useful to look at how the legacy system solved things, it also helps to bring the feature set closer to what other Nostr clients are doing so users don't have such wildly varying experiences across clients with these types of content.

sootisooti commented 2 weeks ago

Event list batch box