search

damus-io / damus

iOS nostr client
GNU General Public License v3.0
2k stars 289 forks source link

Bug: After changing LN address in my profile, I can't see any previous zaps sent to prior addresses. #2432

Open dmnyc opened 4 weeks ago

dmnyc commented 4 weeks ago

I switched my wallet address from daniel@primal.net to thedaniel@getalby.com.

Afterward, my Zap tab displayed no zaps sent to my previous address and only started recording zaps sent to my current one.

In addition, notes where I have received zaps do not show anything prior to the address change.

See the comparison of this note ID shown in Nostur, displaying 7 zaps for a total of over 2000 sats vs. Damus which only displays 1 zap of 3 sats.

note18a0y77xhk7lw0cge0qlyjcyg59n0gjmvhxt3az8w97uhwztgh9fsyqsru9

image image

jb55 commented 4 weeks ago

yes changing lnurl will invalidate older zaps, it's by design

dmnyc commented 4 weeks ago

I don't understand why Damus wouldn't display the total zap count on a note. If a note previously received zaps but someone changed their address at a later time wouldn't it still make sense to show the full amount that is visible on other clients?

https://nostr.band/note18a0y77xhk7lw0cge0qlyjcyg59n0gjmvhxt3az8w97uhwztgh9fsyqsru9

jb55 commented 4 weeks ago

What we can do is mark a zap as valid, at the time of validation, and always maintain that state into the future. We just need to add this note metadata to nostrdb. This is most likey what all these other apps are doing. Damus has a DB but we don't fully integrate into it yet: