search

damus-io / damus

iOS nostr client
GNU General Public License v3.0
2k stars 288 forks source link

Highlighter support on non-safari iOS browsers #2455

Open danieldaquino opened 2 months ago

danieldaquino commented 2 months ago

As a Damus user who is doing highlights on the web, I would like to do that on another browser (not Safari)

Is your feature request related to a problem? Please describe. A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

When does this problem happen?

Describe the solution you'd like A clear and concise description of what you want to happen.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

alltheseas commented 2 months ago

Which browser was requested?

alltheseas commented 1 month ago

Confirmed does not work on brave, firefox iOS

aco-linux commented 1 month ago

It is not working on 3rd party browsers. It would also be nice to have ebook integration. (Libby, kindle, calibre, etc.)

jb55 commented 1 month ago

On Sun, Sep 08, 2024 at 05:44:24PM GMT, aco-linux wrote:

It would also be nice to have ebook integration. (Libby, kindle, calibre, etc.)

there's no way to link to ebooks, but it would be cool if we could add ebook context somehow.

danieldaquino commented 1 month ago

On Sun, Sep 08, 2024 at 05:44:24PM GMT, aco-linux wrote: It would also be nice to have ebook integration. (Libby, kindle, calibre, etc.) there's no way to link to ebooks, but it would be cool if we could add ebook context somehow.

I wonder what would be the best way to reference a passage from a book. An ISBN number, perhaps? That's the most standard and reliable way I can think of.

I have no idea if there are any reliable and standard indexing systems to locate a passage within a book though. I suspect page numbers would make bad immutable reference points as books can be distributed with different sizes (paperback, hard-cover), for different ebook screen sizes, with user-configurable font sizes, line spacing, etc. But perhaps the reference does not need to be this precise.

alltheseas commented 1 month ago

I wonder what would be the best way to reference a passage from a book. An ISBN number, perhaps? That's the most standard and reliable way I can think of.

Yes, and usually also author last name, book name, page number.

alltheseas commented 1 month ago

Agree e-book pages might be different

aco-linux commented 1 month ago

UPDATE: I deleted and added back Damus. iOS now shows "Highlight on Damus" share option via the share icon but not in the long press share option of selected text. I can access Highlight on Damus via third party browser (firefox tested) if I select text, choose markup, then press share icon. I was also able to copy and paste text from Books App and post, the note adds the book and author automatically but no highlight. Kindle does the same and adds a abbreviated link.

Kindle nevent1qqsgdg57evw7hl4d9d592wmwz4h5x4vt9k2ddtjgrajy5de5mvq426qzyqhjn23nc23mghpw7v3p9pujfze0ffy6qq4aphs059kffcfc43h3xqcyqqqqqqgtu8ael

Apple nevent1qqswdypdrr40cd5fxxzs2vcmtyp8k9f5qrt730nmn6yur7ssc8hdsqczyqhjn23nc23mghpw7v3p9pujfze0ffy6qq4aphs059kffcfc43h3xqcyqqqqqqgrh4hds

alltheseas commented 1 month ago

can access Highlight on Damus via third party browser (firefox tested)

@aco-linux I cant reproduce on firefox. Could add screenshots or a video record?

alltheseas commented 1 month ago

Lets separate the e-book discussion from this browser thread here: https://github.com/damus-io/damus/issues/2484