search

damus-io / notedeck

A multiplatform nostr client
Other
93 stars 16 forks source link

Stateful account management #297

Closed kernelkind closed 2 weeks ago

kernelkind commented 3 weeks ago

See attached video for demonstration

https://github.com/user-attachments/assets/081ab112-a616-4784-8b31-d2c87b0ff335

jb55 commented 3 weeks ago

for some reason it flickers when you click the switch button?

jb55 commented 3 weeks ago

oh maybe this is just a preview thing? because of show_account_switcher = false after the SelectAccount action? The window is supposed to close after selection?

jb55 commented 3 weeks ago

looks good at a high level, I will try to integrate it... it's weird to review when its only in previews so I'm not sure if its working or not

kernelkind commented 3 weeks ago

The issue was I was returning early when it detected an account switch was happening. Should be fixed now

kernelkind commented 3 weeks ago

oh maybe this is just a preview thing? because of show_account_switcher = false after the SelectAccount action? The window is supposed to close after selection?

Right now the window is not supposed to close after selection. Also there isn't integration with the account switcher yet because we don't have temporary columns yet.

I was imagining that the closure of the column would happen by the column itself but if we want the widget inside the temporary column to send signals to the column to close I think they should send a response to the column and the column can do that itself

kernelkind commented 3 weeks ago

dropped the commit which used my fork for egui-nav since my PR got merged. Also did cargo update

kernelkind commented 3 weeks ago

rebase with master

jb55 commented 2 weeks ago

I rebased this on my refactor branch. I think we can drop the RoutableWidgetState now, since routes are stored in columns

jb55 commented 2 weeks ago

I think we can drop the RoutableWidgetState now

actually I may call this Router\<Route> and eventually integrate this back into egui-nav (maybe). The returning and navigating states should probably be handled in there.

jb55 commented 2 weeks ago

this is merged in master with a bunch of changes. I am going to work on pushing account management as a route on the first timeline