damus-io / notedeck

A multiplatform nostr client
Other
101 stars 17 forks source link

Create Purple checkout flow that does not require iOS app #330

Open danieldaquino opened 1 month ago

danieldaquino commented 1 month ago

Create Purple checkout flow that does not require iOS app, so that we can provide early Notedeck access to Purple members

Suggested-by: @ vrod

alltheseas commented 1 month ago

Notedeck rollout proposed timing / plan: 1) finish alpha milestone remaining tickets https://github.com/damus-io/notedeck/milestone/1 2) internal damus team testing (can happen same time as 3)) 3) purple subscriber testing (early access is, and should be underlined as purple increased dev team access) 4) non-purple subscriber waitlist access, testing (as long as this follows 3), it is fine; e.g. one week after 3)/after some feedback loop, iterations, and improvements per purple customer feed back)

all purple subscribers should get access immediately to notedeck

alltheseas commented 1 month ago

@danieldaquino to investigate in prep for notedeck launch

danieldaquino commented 1 month ago

Almost done and ready to go!

Done:

Still in progress:

These items will probably take only a few hours

Draft PRs:

danieldaquino commented 1 month ago

@jb55 @alltheseas, finished editing the PRs and extensively tested them:

(This took longer than expected because there were many edge cases and preconditions to be tested, and several small details to be fixed/tweaked)

I recommend reviewing the server-side first, client-side second. I also highly recommend reviewing commit by commit instead of all changes at once on the website PR as many changes had to be made there.

Please let me know if there are any questions or concerns. Thank you!

jb55 commented 1 month ago

@danieldaquino thanks! back now so reviewing soon

alltheseas commented 1 month ago

Without going into the individual commits the only thought I have is will customers want to subscribe to notedeck using a fiat payment mechanism, and do we want to add fiat checkout prior to notedeck launch

alltheseas commented 4 weeks ago

@jb55 to review

alltheseas commented 4 weeks ago

moving from sprint 25 to 26 (starting oct 14 2024)

danieldaquino commented 4 weeks ago

Deployment update: Server-side changes were deployed to our staging server

jb55 commented 2 weeks ago

Deployment update: Server-side changes were deployed to our staging server

I tried to signup on the website on staging, but it doesn't seem to be giving me an OTP option?

Screenshot 2024-10-23 at 10 52 09

danieldaquino commented 2 weeks ago

Deployment update: Server-side changes were deployed to our staging server

I tried to signup on the website on staging, but it doesn't seem to be giving me an OTP option?

Screenshot 2024-10-23 at 10 52 09

I haven't merged and deployed the client-side yet. I will do that now, please give me one moment!

danieldaquino commented 1 week ago

@jb55, I merged those fixes for the OTP checkout flow, and deployed to https://staging.damus.io.

Please let me know if that fixes the issue you were seeing, and if it looks good for deployment at production!