search

damus-io / notedeck

A multiplatform nostr client
Other
47 stars 9 forks source link

Integrate sidebar #80

Closed jb55 closed 1 month ago

jb55 commented 1 month ago

This follows from:

It hooks up the sidebar into our UI, but we still need to make the buttons work and implement a design:

kernelkind commented 1 month ago

Run ./preview DesktopGlobalPopup to see an example with accounts populated. I didn't change the StateInMemory (formerly PersistedState) conception yet to not use static IDs because I can't think of a better solution yet. Let me know what you think @jb55

jb55 commented 1 month ago

let's not merge master into this, I will rebase it

jb55 commented 1 month ago

see git range-diff 1b0de88173c9...df0377cb891c for rebase diff

jb55 commented 1 month ago

all this will need to be refactored. There is too much global state everywhere, and many of the components are needlessly touching global state when they can simply return individual responses. I will start on this refactoring to show what I mean. ideally don't do any more work on this branch until we get this sorted.

jb55 commented 1 month ago

I'm happy the state this is in for now, even if the sidebar is non-functional. We have click handling states at least! Wanted to merge this since there are a bunch of changes and I don't want this to get too out of sync with master.

Working on nav so that we can re-add the global popup.