search

dan-c-underwood / vscode-arm

Arm® Syntax highlighting for VSCode
MIT License
41 stars 19 forks source link

Less aggressive comment highlighting #19

Open MandL27 opened 4 years ago

MandL27 commented 4 years ago

Currently, the extension marks @ or ; to end of line as a comment, which can be problematic when an assembler only uses one for comments and uses the other as part of labels. Adding a workspace-level configuration option to change comment character(s) for highlighting would resolve this.

dan-c-underwood commented 4 years ago

Hey - I'll try and take a look at this over the next week or so. I'll need to work out how to do it, but I'll try to figure it out 🙂

dan-c-underwood commented 4 years ago

Sorry for the delay in coming back on this, unfortunately there appears to be no simple way of adding this as a configuration option currently. Comments and syntax fall under declarative language features rather than programmatic. So VSCode doesn't provide an option, as of yet, to easily modify them on the fly.

I'll leave this issue open though, and will add this feature if VSCode provides a hook that can be easily used in the future.

etylermoss commented 3 years ago

Encountering the same issue, GAS uses ; the same as C, as a linebreak, so you can have multiple statements on a single line, which here is marks the entire line as a comment.

Edit: Is there any relevant issues open on VSCode you're aware of talking about this limitation?

dan-c-underwood commented 3 years ago

Nope - but I've just opened one and referenced this issue 🙂