dan-coulter / phpflickr

PHP Wrapper for the Flickr API
GNU General Public License v2.0
207 stars 128 forks source link

Default structure has changed in #9 #31

Closed barryvdh closed 2 years ago

barryvdh commented 10 years ago

Before #9, title and description would return a text, after the changes they return an array with _content. I understand that this is default behavior from Flickr, but this does break applications using the old structure by default.

Was this intentional or something that slipped through?

barryvdh commented 10 years ago

The affected lines: https://github.com/dan-coulter/phpflickr/blob/master/phpFlickr.php#L307-L313

/*
 * Uncomment this line (and comment out the next one) if you're doing large queries
 * and you're concerned about time.  This will, however, change the structure of
 * the result, so be sure that you look at the results.
 */
$this->parsed_response = json_decode($this->response, TRUE);
/* $this->parsed_response = $this->clean_text_nodes(json_decode($this->response, TRUE)); */

Before, the first line was commented out, but the commit changed that.

dan-coulter commented 10 years ago

I missed that on a merge from someone's pull request. Go ahead and reverse that comment and I'll do the same for future versions.

barryvdh commented 10 years ago

So you want to keep the current behavior and only change the comment ? Op 18 jul. 2014 18:13 schreef "Dan Coulter" notifications@github.com:

I missed that on a merge from someone's pull request. Go ahead and reverse that comment and I'll do the same for future versions.

— Reply to this email directly or view it on GitHub https://github.com/dan-coulter/phpflickr/issues/31#issuecomment-49449520 .

dan-coulter commented 10 years ago

No. I'm going to change it back to the old behavior. That merge also broke it for people on PHP 5.1, so I'm probably going to take out some of the other changes it made.

barryvdh commented 10 years ago

Cool Op 18 jul. 2014 18:36 schreef "Dan Coulter" notifications@github.com:

No. I'm going to change it back to the old behavior. That merge also broke it for people on PHP 5.1, so I'm probably going to take out some of the other changes it made.

— Reply to this email directly or view it on GitHub https://github.com/dan-coulter/phpflickr/issues/31#issuecomment-49452120 .