search

dan-coulter / phpflickr

PHP Wrapper for the Flickr API
GNU General Public License v2.0
207 stars 128 forks source link

Message: Methods with the same name as their class will not be constructors in a future version of PHP; phpFlickr_pager has a deprecated constructor #85

Closed gskhattra87 closed 2 years ago

gskhattra87 commented 5 years ago

Message: Methods with the same name as their class will not be constructors in a future version of PHP; phpFlickr has a deprecated constructor

Filename: phpflickr/phpFlickr.php

Line Number: 25

Message: Methods with the same name as their class will not be constructors in a future version of PHP; phpFlickr_pager has a deprecated constructor

Filename: phpflickr/phpFlickr.php

Line Number: 1702

TommyBloom commented 5 years ago

Any news on this? I know that there is another issue that has a fork that apparently has a fix. That fork doesn't work with my drupal plugin.

samwilson commented 5 years ago

What error are you getting with your Drupal plugin?

TheKLF99 commented 3 years ago

Change the function names on lines 62 and 1703 to read __construct instead of the class name - as long as nothing in the class calls the functions own name then it should work - I've searched the code and I can't see anything that calls the constructor inside the class. I've just made that alteration myself and will see later on today if it works.

samwilson commented 3 years ago

I've fixed this issue in my fork of this package.