search

dan-coulter / phpflickr

PHP Wrapper for the Flickr API
GNU General Public License v2.0
207 stars 128 forks source link

Fixed DB caching, moved to JSON communication #9

Closed mikeMTOL closed 10 years ago

mikeMTOL commented 10 years ago

DB caching wasn’t working, changed the SQL commands to utilize ON DUPLICATE statement. Moved from php_serialization to json for API, meter for moving forward.

dan-coulter commented 10 years ago

I marked up a bunch of style issues I have with this changeset.

Also, what is your reasoning for using JSON? Serialized PHP does take more storage when you're caching it, but deserializing it is faster than JSON.

mikeMTOL commented 10 years ago

Yea I noticed your changes.

The thinking behind json is that it's more universal out there. If you want to feed this data to an Ajax script it's one less conversion.

Also if you need to move it to ruby or python shells it will take on less conversion. What do you think?

M

On May 25, 2014, at 8:28 PM, Dan Coulter notifications@github.com wrote:

I marked up a bunch of style issues I have with this changeset.

Also, what is your reasoning for using JSON? Serialized PHP does take more storage when you're caching it, but deserializing it is faster than JSON.

— Reply to this email directly or view it on GitHub.

mikeMTOL commented 10 years ago

I've implemented the formatting changes you requested, let me know if theres anything else you need done.

mikeMTOL commented 10 years ago

hey Danco, any news about the pull request? thanks.