search

dan-divy / spruce

A social networking platform made using Node.js and MongoDB
MIT License
500 stars 114 forks source link

Persist images using cloudinary #59

Closed universallythinking closed 4 years ago

universallythinking commented 4 years ago

I edited ROUTES/API/V1/INDEX.JS and ROUTES/SETTINGS.JS and added CONFIG/CLOUDINARY.JS so that images persist.

littledivy commented 4 years ago

@universallythinking TYSM, there are merge conflicts with the master branch, could you please resolve them?

(cc @dan-online)

dan-online commented 4 years ago

Looks good, as @divy-work said, there are some merge conflicts so it would be great if you could resolve those first

dan-online commented 4 years ago

Also can you make cloudinary optional, if someone does not wish to use it or doesn't have it setup, pfp upload errors.

universallythinking commented 4 years ago

I'm not seeing any conflicts, but I could be missing something... Cloudinary is now optional, with env variables.

dan-online commented 4 years ago

image

Here are the merge conflicts

universallythinking commented 4 years ago

Screen Shot 2020-06-27 at 3 50 02 PM

It doesn't look like I have those permissions...

universallythinking commented 4 years ago

Give me a sec

universallythinking commented 4 years ago

Should be good to go...

littledivy commented 4 years ago

LGTM, Merging...