Fix export.py - Githubissues

dan-fritchman / Hdl21

Hardware Description Library

BSD 3-Clause "New" or "Revised" License

69 stars 16 forks source link

Fix export.py #169

Closed growly closed 1 year ago

growly commented 1 year ago

Export script would produce duplicate modules, one copy with parameters and one without. No longer.
File header comment now passably useful.
PDK name used for export now comes from pdk_data.py.
Script itself moved to ../scripts directory.

codecov[bot] commented 1 year ago

Codecov Report

Merging #169 (f61bc0c) into main (5c0daad) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #169   +/-   ##
=======================================
  Coverage   87.20%   87.20%           
=======================================
  Files         109      109           
  Lines        9577     9577           
=======================================
  Hits         8352     8352           
  Misses       1225     1225

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

growly commented 1 year ago

I'm pretty sure the failing dev tests are exclusively due to the changes to Vlsir protos upstream, and are fixed by #172

dan-fritchman commented 1 year ago

This ready to merge?