dan-german / blocks

user-friendly cross-platform modular synth
GNU General Public License v3.0
130 stars 14 forks source link

fix: preset loading for Bitwig #36

Closed kzantow closed 3 months ago

kzantow commented 3 months ago

When restoring a preset in Bitwig, not everything got updated, which resulted in problems with the patch including the levels not being set and an empty GUI the first time it's opened. This change just moves where one of the updates happens so it is consistent when the pending_preset_ is used. It's unclear why this did not cause a problem in other hosts, but I only saw the issue in Bitwig. Apologies, but I really don't know a good way to write a test for this, otherwise I'd include one 😬