dan-r / HomeAssistant-NissanConnect

Unofficial Home Assistant integration for interacting with Nissan Connect vehicles 🚗
Apache License 2.0
26 stars 6 forks source link

Merge my Japan NissanConnect implementation? #32

Open developerfromjokela opened 1 week ago

developerfromjokela commented 1 week ago

Hi.

I've forked your repo and implemented Japanese Domestic Market's NissanConnect app. Here's the repo: https://github.com/developerfromjokela/HomeAssistant-NissanConnect-JP.

I think maybe if we somehow merge it into the main repo so we don't have two identical applications :D

dan-r commented 1 week ago

I agree it's a good idea to get it merged. Leave it with me and I'll merge your changes.

Happy to make you a contributor for this repo too so you can maintain the Japan side

dan-r commented 1 week ago

@developerfromjokela I've made a start on the changes in the japan branch. Would you mind testing these?

https://github.com/dan-r/HomeAssistant-NissanConnect/tree/japan