dan-snelson / dialog-scripts

Scripts with leverage Bart Reardon's swiftDialog
MIT License
110 stars 35 forks source link

`"path":` in `policy_array` as command #21

Closed amyers22 closed 1 year ago

amyers22 commented 1 year ago

Currently the "path": in policy_array is configured to look for a file path for verification the listitem completed. Would it be possible to add a command option for verification based on its output?

https://github.com/dan-snelson/dialog-scripts/blob/5864bb613e1eda306bf5a0f553dc945cb59ea2fa/Setup%20Your%20Mac/Setup-Your-Mac-via-Dialog.bash#L1235-L1247

dan-snelson commented 1 year ago

Thanks for the Feature Request, @amyers22.

Are you able to share a sanitized code sample for testing purposes?

dan-snelson commented 1 year ago

@amyers22: A quick reminder that Iā€™m waiting on you for additional information; please above. Thanks.

amyers22 commented 1 year ago

Not currently. This was more around the ability for the path to be set with something like fdesetup status and if its not on then the policy didnt complete. I know there are file paths to check for FileVault, but this would just be an example of a command output I would want to compare to.

dan-snelson commented 1 year ago

@amyers22 and @mbracco1973:

Please test-drive 1.6.0-rc1.

Screenshot 2022-12-14 at 6 46 29 AM

NOTES:

dan-snelson commented 1 year ago

@amyers22 and @mbracco1973:

Screenshot 2022-12-14 at 6 41 58 PM

Setup Your Mac (1.6.0-rc3)

Addresses Issue No. 21

dan-snelson commented 1 year ago

Setup Your Mac (1.6.0-rc5)

Screenshot 2022-12-16 at 5 22 17 AM
dan-snelson commented 1 year ago

Setup Your Mac (1.6.0-rc6)

Screenshot 2022-12-16 at 12 54 06 PM
amyers22 commented 1 year ago

I dont deploy Sophos or GlobalProtect, but the FileVault validation works great!

dan-snelson commented 1 year ago

Thanks for confirming, @amyers22.

dan-snelson commented 1 year ago

Addressed in Setup Your Mac (1.6.0).