search

dan-snelson / dialog-scripts

Scripts with leverage Bart Reardon's swiftDialog
MIT License
110 stars 35 forks source link

Code clean up - does policy_array in Setup-Your-Mac-via-Dialog.bash, still need to be a shell array? #39

Closed wakco closed 1 year ago

wakco commented 1 year ago

Not really a bug or a feature, more just code clean up.

Loving the use of JavaScript via osascript to handle reading JSON content, however I noticed something that I assume is to be cleaned up at some point. I assume this is a hangover from a DEPNotify based script, but I am struggling to see a reason why policy_array is still a shell array when it only contains one long JSON formatted string.

Figured I'd log it here as a helpful reminder to clean up policy_array, as I haven't gone through enough of the script yet to consider creating a pull request that cleans this up.

dan-snelson commented 1 year ago

Thanks, @wakco; PRs are always welcome.

wakco commented 1 year ago

Thank you.