dan200 / ComputerCraft

Programmable Computers for Minecraft
Other
980 stars 198 forks source link

[Question] Support for custom models in Resource Packs #296

Closed vico93 closed 7 years ago

vico93 commented 7 years ago

Sorry to resurrect this issue, but does ComputerCraft 1.80 w/ Unborked 1.11.2 supports resource packs? I tried to adapt @ObloxCC 's model proposed in #202 (repository for the custom resource pack here) but it gives me the checkered texture and the computer won't rotate when placed:

2017-05-30_13 08 59

So my question is: Does ComputerCraft (specifically 1.80 w/ Unborked for 1.11.2) accepts custom models via resource packs or the model json is somewhat messed up?

Thanks for the patience

dan200 commented 7 years ago

I can think of no reason why it wouldn't accept them.

On 30 May 2017 at 17:10, Vinícius Pontin notifications@github.com wrote:

Sorry to resurrect this issue, but does ComputerCraft 1.80 w/ Unborked 1.11.2 supports resource packs? I tried to adapt @ObloxCC https://github.com/obloxcc 's model proposed in #202 https://github.com/dan200/ComputerCraft/issues/202 (repository for the custom resource pack here https://github.com/vicocraft/computercraft_3d) but it gives me the checkered texture and the computer won't rotate when placed:

[image: 2017-05-30_13 08 59] https://cloud.githubusercontent.com/assets/3485505/26593077/38aecd98-4539-11e7-8bc4-fd985391b447.png

So my question is: Does ComputerCraft (specifically 1.80 w/ Unborked for 1.11.2) accepts custom models via resource packs or the model json is somewhat messed up?

Thanks for the patience

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dan200/ComputerCraft/issues/296, or mute the thread https://github.com/notifications/unsubscribe-auth/AB3bbHmn2x08tsW9OWwRojLk24tY_Tkkks5r_D9tgaJpZM4NqhGY .

SquidDev commented 7 years ago

In each file you define the textures as top, side and front. However the models just refer to 0, 1 and 2. The PR here looks like it uses the correct keys, so you might want to copy the files from there.

Also, unless you're using Plethora or CCTweaks, you can use the 1.11.2 PR which is significantly less hacky and has all of the new CC features included.

vico93 commented 7 years ago

Thanks a lot Mr. @SquidDev , i will switch to 1.11.2 PR, use the PR you've indicated and wait for CCTweaks and Plethora to be updated 😜

vico93 commented 7 years ago

Actually i have a problem with the 1.11.2 CC fork @SquidDev have pointed. https://gist.github.com/vpontin/4d370501df06d2fa1f8c45c878fe71f4 But i dont know where i would file an issue

KnightMiner commented 7 years ago

The build task in Gradle does not currently copy the luaj dependency into the jar. You will have to either use the deploy script or just copy the luaj jar from libs.

ObloxCC commented 7 years ago

@vpontin If you want or need any help with this you can message/ask me. Also if you want I can fix the models to use the correct naming.

vico93 commented 7 years ago

@KnightMiner thanks a lot! I will try to build myself the fork. @ObloxCC Sadly GitHub doesnt have any PM feature, so i'll throw up the problem here: When i place a Computer using your model, it always face the opposite direction it should be. If you look my repository you will see the only commit i've made was fixing 1.11.x item names, I tried to fix myself but no avail, and i've tried to open the model on the MrCrayfish's Model Creator, and it wont open. Thank you a lot for offering to help me, and feel free to PR the repo with changes!

vico93 commented 7 years ago

@KnightMiner sadly i cant managed to build @SquidDev 's fork correctly, due to the problem Knight mentioned before (the compilation process doesnt account the luaj library).

SquidDev commented 7 years ago

@vpontin Sorry, until #186 is merged you'll also need to include luaj-jse-2.0.3.jar in the mods folder.

Alternatively, if you fancy building from source, you can use the ./deploy.sh script and use the jar in the deploy folder.